Fix an issue where the error message 'UndefinedObject: Undefined object section' is being incorrectly reported. (#732)

Author: karreiro

lib/theme_check/shopify_liquid/source_index.rb

@@ -22,7 +22,7 @@ def objects
             load_file(:objects)
               .concat(built_in_objects)
               .filter_map do |hash|
-                next if (theme_app_extension_labels + labels_only_exposed_in_certain_contexts).include?(hash['name'])
+                next if labels_only_exposed_in_certain_contexts.include?(hash['name'])
 
                 ObjectEntry.new(hash)
               end
@@ -45,7 +45,7 @@ def theme_app_extension_labels
         end
 
         def labels_only_exposed_in_certain_contexts
-          ['robots'].freeze
+          ['robots', 'app'].freeze
         end
 
         def deprecated_filters

test/checks/undefined_object_test.rb

@@ -450,6 +450,16 @@ def test_report_on_app_liquid_drop_in_themes
     END
   end
 
+  def test_does_not_report_when_section_is_used
+    offenses = analyze_theme(
+      ThemeCheck::UndefinedObject.new(exclude_snippets: false),
+      "blocks/block_a.liquid" => <<~END,
+        <p>{{ section.id }}</p>
+      END
+    )
+    assert_offenses("", offenses)
+  end
+
   def test_does_not_report_on_app_liquid_drop_in_theme_app_extensions
     offenses = analyze_theme(
       ThemeCheck::UndefinedObject.new(exclude_snippets: false, config_type: :theme_app_extension),