Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Page throws error #1

Open
adrian-szwejk opened this issue Jun 11, 2023 · 2 comments
Open

Login Page throws error #1

adrian-szwejk opened this issue Jun 11, 2023 · 2 comments
Labels
invalid This doesn't seem right priority: medium describes the immediacy of attention required

Comments

@adrian-szwejk
Copy link
Contributor

When testing app out and trying to login without filling anything out, it would show a popup saying "[firebase_auth/unknown] Given String is smpty or Null instead of not letting the user try to login until they've filled out both TextFields. Same issues for emails that aren't formatted properly: "test" intead of "[email protected]" and for when format is valid but user doesn't exist.

@adrian-szwejk adrian-szwejk added bug invalid This doesn't seem right and removed bug labels Jun 11, 2023
@ashah305
Copy link
Contributor

Hey, I made it so you have to make an account with the proper email base on the sign up page and then from there in order to login you have to type the email and password -- is that what you mean is the issue? I think an error will show up in any other case.

@adrian-szwejk
Copy link
Contributor Author

Yeah, I fixed the formatting of the email text field with some regexp functions to test string formatting however you can still make a request with the incorrect format (At least when I pushed), so I think we gotta a boolean variable or someway for the app to not make a request until the formatting is correct and even after we should make the UI nicer for why it failed (Like "Account doesn't exists, try again")

@adrian-szwejk adrian-szwejk added priority: high describes the immediacy of attention required priority: medium describes the immediacy of attention required and removed priority: high describes the immediacy of attention required labels Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right priority: medium describes the immediacy of attention required
Projects
None yet
Development

No branches or pull requests

2 participants