Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bstr #137

Open
goto-bus-stop opened this issue Jun 18, 2020 · 0 comments
Open

Use bstr #137

goto-bus-stop opened this issue Jun 18, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@goto-bus-stop
Copy link
Member

a lot of map scripts are written in different encodings, especially older ones. currently we run chardet on those but there's really no reason to convert them to utf8. the builtin tokens are all ascii and the game works on a byte level with custom const names anyway. with bstr we could treat non utf8 stuff as a str.
@goto-bus-stop goto-bus-stop added the enhancement New feature or request label Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@goto-bus-stop