Skip to content

Commit 67eec35

Browse files
committed
#1390: Removed stragglers duplicate definition get_two_letter_dir
1 parent 1a0d0e5 commit 67eec35

File tree

2 files changed

+3
-18
lines changed

2 files changed

+3
-18
lines changed

signbank/video/models.py

+1-9
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,6 @@
2727
from signbank.dictionary.models import Gloss, Language
2828

2929

30-
def get_two_letter_dir(idgloss):
31-
foldername = idgloss[:2]
32-
33-
if len(foldername) == 1:
34-
foldername += '-'
35-
36-
return foldername
37-
38-
3930
class GlossVideoStorage(FileSystemStorage):
4031
"""Implement our shadowing video storage system"""
4132

@@ -133,6 +124,7 @@ class Meta:
133124

134125
def get_gloss_path_to_video_file_on_disk(gloss):
135126
idgloss = gloss.idgloss
127+
from signbank.tools import get_two_letter_dir
136128
two_letter_dir = get_two_letter_dir(idgloss)
137129
dataset_dir = gloss.lemma.dataset.acronym
138130
filename = idgloss + '-' + str(gloss.id) + '.mp4'

signbank/zip_interface.py

+2-9
Original file line numberDiff line numberDiff line change
@@ -213,15 +213,6 @@ def uploaded_zip_archives(dataset):
213213
return zip_archive
214214

215215

216-
def get_two_letter_dir(idgloss):
217-
foldername = idgloss[:2]
218-
219-
if len(foldername) == 1:
220-
foldername += '-'
221-
222-
return foldername
223-
224-
225216
def get_gloss_filepath(video_file_path, gloss):
226217

227218
filename = os.path.basename(video_file_path)
@@ -245,6 +236,7 @@ def get_gloss_filepath(video_file_path, gloss):
245236
if annotation_text != filename_without_extension:
246237
# gloss annotation does not match zip file name
247238
return "", "", ""
239+
from signbank.tools import get_two_letter_dir
248240
two_letter_dir = get_two_letter_dir(gloss.idgloss)
249241
destination_folder = os.path.join(
250242
settings.WRITABLE_FOLDER,
@@ -284,6 +276,7 @@ def get_gloss_filepath_glossid(video_file_path, gloss):
284276
if glossid != filename_without_extension:
285277
# gloss id does not match zip file name
286278
return "", "", ""
279+
from signbank.tools import get_two_letter_dir
287280
two_letter_dir = get_two_letter_dir(gloss.idgloss)
288281
destination_folder = os.path.join(
289282
settings.WRITABLE_FOLDER,

0 commit comments

Comments
 (0)