Skip to content

Commit 6ad5192

Browse files
authored
Merge pull request #1428 from Signbank/search_query_type
#1427: Removed Max Scroll Bar limit on Gloss Search
2 parents 6181c46 + c7a847c commit 6ad5192

File tree

1 file changed

+9
-16
lines changed

1 file changed

+9
-16
lines changed

signbank/dictionary/adminviews.py

+9-16
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@ def order_annotatedsentence_queryset_by_sort_order(get, qs, queryset_language_co
9494
"""
9595

9696
def order_queryset_by_annotatedglosses(qs, sOrder):
97-
print(sOrder)
9897
# filter query on dataset and sort based on first gloss of the sentence
9998
qs = qs.annotate(
10099
firstgloss=Subquery(
@@ -527,19 +526,8 @@ def get_context_data(self, **kwargs):
527526

528527
this_page_number = context['page_obj'].number
529528
this_paginator = context['page_obj'].paginator
530-
if len(self.object_list) > settings.MAX_SCROLL_BAR:
531-
this_page = this_paginator.page(this_page_number)
532-
if this_page.has_previous():
533-
previous_objects = this_paginator.page(this_page_number - 1).object_list
534-
else:
535-
previous_objects = []
536-
if this_page.has_next():
537-
next_objects = this_paginator.page(this_page_number + 1).object_list
538-
else:
539-
next_objects = []
540-
list_of_objects = previous_objects + list(context['page_obj'].object_list) + next_objects
541-
else:
542-
list_of_objects = self.object_list
529+
530+
list_of_objects = self.object_list
543531

544532
# construct scroll bar
545533
# the following retrieves language code for English (or DEFAULT LANGUAGE)
@@ -6687,6 +6675,8 @@ def get_context_data(self, **kwargs):
66876675

66886676
context['searchform'] = search_form
66896677

6678+
context['search_type'] = self.search_type
6679+
66906680
multiple_select_gloss_fields = ['tags']
66916681
context['MULTIPLE_SELECT_GLOSS_FIELDS'] = multiple_select_gloss_fields
66926682

@@ -6715,8 +6705,9 @@ def get_queryset(self):
67156705
# the query set is a list of tuples (gloss, keyword_translations, senses_groups)
67166706
return []
67176707

6718-
if ('search_type' in self.request.session.keys() and
6719-
self.request.session['search_type'] != self.search_type):
6708+
session_search_type = self.request.session.get('search_type' '')
6709+
6710+
if session_search_type != self.search_type:
67206711
feedback_message = _('Your query result is not glosses.')
67216712
messages.add_message(self.request, messages.ERROR, feedback_message)
67226713
# the query set is a list of tuples (gloss, keyword_translations, senses_groups)
@@ -6754,6 +6745,8 @@ def get_queryset(self):
67546745
TaggedItem.objects.filter(tag__id__in=values).values_list('object_id', flat=True))
67556746
glosses_of_datasets = glosses_of_datasets.filter(id__in=glosses_with_tag)
67566747

6748+
glosses_of_datasets = glosses_of_datasets.order_by('lemma__lemmaidglosstranslation__text')
6749+
67576750
(interface_language, interface_language_code,
67586751
default_language, default_language_code) = get_interface_language_and_default_language_codes(self.request)
67596752

0 commit comments

Comments
 (0)