Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The video overwriting/relinking problem still exists if you rename a gloss #1492

Closed
Woseseltops opened this issue Feb 7, 2025 · 3 comments · Fixed by #1495
Closed

The video overwriting/relinking problem still exists if you rename a gloss #1492

Woseseltops opened this issue Feb 7, 2025 · 3 comments · Fixed by #1495
Labels

Comments

@Woseseltops
Copy link
Collaborator

The problem we analyzed in #1453 is apparently still present if you rename glosses. @rem0g reports:

Glos AAP was aangepast naar AAP-A, video links en midden en NMM video zijn dan weg. Er blijft dan alleen video rechts over en deze zit ook in NMM index 0

@Woseseltops Woseseltops added the bug label Feb 7, 2025
@susanodd
Copy link
Collaborator

The original videos of a deleted gloss are not deleted.

This should only apply if you rename the Lemma, not the Annotation. The video filename includes the name of the Lemma. (@vanlummelhuizen to solve this, I thought he did solve this?)

I told you in the office on Thursday, there are still many NME videos that point to the normal video.

@susanodd
Copy link
Collaborator

susanodd commented Feb 10, 2025

I copied the production database to signbank-susan where the video admin commands live. (1 PM 10 February 2025)

There are still 37 glosses with an NME video that points to the normal video.

There are still 90 glosses with a Perspective video that points to the normal video.

This is likely the cause of the above error.

vanlummelhuizen added a commit that referenced this issue Feb 10, 2025
@vanlummelhuizen vanlummelhuizen linked a pull request Feb 10, 2025 that will close this issue
@vanlummelhuizen
Copy link
Collaborator

Fixed it. See #1495.

Woseseltops added a commit that referenced this issue Feb 13, 2025
…nking-problem-still-exists-if-you-rename-a-gloss

fix: Applied fix for #1453; #1492
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants