-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domino effect on video deletion #1502
Comments
@vanlummelhuizen if you're there, shall I just go ahead and do this? Or do you want to do this? I'm not supposed to keep assigning myself to issues.. :) |
@susanodd Please only work on things you discussed with @Woseseltops . So not this issue. |
The changes requested to #1398 asked for the method delete_files to return a Boolean result. In making this change it was on topic to test whether the filename was correct. If it points to the normal video, the filename is erased from the object instead of deleting the file. |
for symmetry. Also takes care of #1502 by checking if filename is correct before deleting
This is related to #1453
Because there still exist NME and Perspective videos that point to the "normal" video, the delete video for these subclasses ought to be revised.
The Python command os.unlink in fact deletes the file, not merely remove a symbolic link to it.
Thus, when either an NME or Perspective video that points to a "normal" video is deleted, so is the "normal video file".
Modify the delete code to make sure the filename does not point to the wrong kind of video.
The pull request #1398 for video admin does something like this to avoid accidental unintentional domino deletion of normal video files.
The text was updated successfully, but these errors were encountered: