Skip to content

Commit ea26a45

Browse files
committed
upload: Allow relative between different uploaders
When originally adding Uploader, we didn't allow relative between different uploaders to be safe / prevent risk of mistakes. It seems like there's a decently large use case for this though, so switch to allowing it. Topic: relup Uploader: who Reviewers: aaron, brian-k
1 parent 159f964 commit ea26a45

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

revup/topic_stack.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -647,16 +647,6 @@ async def populate_relative_reviews(self, uploader: str, branch_format: str) ->
647647
f" {topic.tags[TAG_BRANCH]} for topic {name}"
648648
)
649649

650-
if (
651-
topic.tags[TAG_UPLOADER]
652-
and topic.relative_topic
653-
and topic.tags[TAG_UPLOADER] != topic.relative_topic.tags[TAG_UPLOADER]
654-
):
655-
raise RevupUsageException(
656-
f"Topic {name} has uploader '{topic.tags[TAG_UPLOADER]}' while relative topic"
657-
f" {topic.relative_topic.name} has uploader"
658-
f" {topic.relative_topic.tags[TAG_UPLOADER] or '{}'}"
659-
)
660650
topic_uploader = min(topic.tags[TAG_UPLOADER]) if topic.tags[TAG_UPLOADER] else uploader
661651
topic_branch_format = (
662652
min(topic.tags[TAG_BRANCH_FORMAT]).lower()

0 commit comments

Comments
 (0)