ESP8266 'ARDUINO_BOARD_ID' bug still around

[Gord1]

With reference to #1554 This is the same problem except that it is in V5 recent build and I thought it was supposed to have been fixed.

The error:

SloeberV5_Dev/arduinoPlugin/packages/esp8266/hardware/esp8266/3.1.2/libraries/ESP8266mDNS/src/LEAmDNS.cpp: In member function 'const void* esp8266::MDNSImplementation::MDNSResponder::enableArduino(uint16_t, bool)':
: error: 'd1_mini_clone' was not declared in this scope
/SloeberV5_Dev/arduinoPlugin/packages/esp8266/hardware/esp8266/3.1.2/libraries/ESP8266mDNS/src/LEAmDNS.cpp:1275:55: note: in expansion of macro 'ARDUINO_BOARD_ID'
1275 | || (!addServiceTxt(hService, "board", ARDUINO_BOARD_ID))
| ^~~~~~~~~~~~~~~~

I am using the ESP8266 D1 Mini Clone. The 'd1_mini_clone' refers to the base in the boards.sloeber.txt or boards.txt file, I believe (e.g.
d1_mini_clone.name=LOLIN(WEMOS) D1 mini (clone)
d1_mini_clone.build.board=ESP8266_WEMOS_D1MINI
d1_mini_clone.build.variant=d1_mini
d1_mini_clone.upload.tool=esptool
d1_mini_clone.upload.maximum_data_size=81920
... and so on

The compile line has:
'-DARDUINO_BOARD="ESP8266_WEMOS_D1MINI"' -DARDUINO_BOARD_ID="d1_mini_clone"

I noticed that the quotes around '-DARDUINO_BOARD="ESP8266_WEMOS_D1MINI"' is different than around
-DARDUINO_BOARD_ID="d1_mini_clone"
if that makes a difference.

Description Resource Path Location Type
Invalid arguments '
Candidates are:
void * addServiceTxt(const void *, const char *, const char *)
void * addServiceTxt(const void *, const char *, unsigned int)
void * addServiceTxt(const void *, const char *, unsigned short int)
void * addServiceTxt(const void *, const char *, unsigned char)
void * addServiceTxt(const void *, const char *, int)
void * addServiceTxt(const void *, const char *, short int)
void * addServiceTxt(const void *, const char *, signed char)
' LEAmDNS.cpp /BoatTelemetry/arduino/Release/libraries/ESP8266mDNS/src line 1275 Semantic Error

Some ideas for a temporary fix or a permanent fix would be helpful. Thanks!

[jantje]

This issue seems different from #1554.
1554 is about the command line being wrong for -DARDUINO_BOARD_ID

Sloeber generates -DARDUINO_BOARD_ID="" instead of the expected -DARDUINO_BOARD_ID="generic" (as boards.txt generic.... that is selected)

Where this issue states

'-DARDUINO_BOARD="ESP8266_WEMOS_D1MINI"' -DARDUINO_BOARD_ID="d1_mini_clone"

Given the error you get
: error: 'd1_mini_clone' was not declared in this scope ... in expansion of macro 'ARDUINO_BOARD_ID'

The DARDUINO_BOARD_ID is defined as d1_mini_clone but d1_mini_clone is not defined/declared.

[Gord1]

The DARDUINO_BOARD_ID is defined as d1_mini_clone but d1_mini_clone is not defined/declared.

I took that the compiler thought that d1_mini_clone was a variable rather than a string, which is what (!addServiceTxt(hService, "board", ARDUINO_BOARD_ID)) is looking for.

In SloeberV5_Dev/arduinoPlugin/packages/esp8266/hardware/esp8266/3.1.2 you have created a platform.sloeber.txt file and added
some single quotes around ARDUINO_BOARD but not around ARDUINO_BOARD_ID.

'-DARDUINO_BOARD="${build.board}"' -DARDUINO_BOARD_ID="${_id}"

In the top of the LEAmDNS.cpp file, if ARDUINO_BOARD_ID is not defined then it gets defined as "generic".

This is beyond my pay grade and I have a very limited understanding what is going on here.
Thanks for looking into it.

[jantje]

If I understand it correctly you are saying addServiceTxt takes a string as 3th parameter (ARDUINO_BOARD_ID in this case).
Sloeber V5.0 interpretation of the platform.txt of the ESP8266 does not result in ARDUINO_BOARD_ID being coded as a string which results in the error 'd1_mini_clone' was not declared in this scope because ARDUINO_BOARD_ID resolves to d1_mini_clone but is expected to resolve to "d1_mini_clone".
If my understanding is correct this is not #1554 but a ESP8266 platform specific problem when using the ESP8266mDNS library.

In other words: the ESP8266 platform provided hardware library ESP8266mDNS assumes the macro ARDUINO_BOARD_ID contains a string value but Sloeber V5 does not provide a string value.

First we need to find out what the correct content of the platform.sloeber.txt should be for your OS (I assume linux)
So I propose you modify the platform.sloeber.txt (start by adding the single quotes you already mentioned)
Save the file; go to project properties->sloeber select apply close
Check whether it is fixed.

If I know what the correct command is I can check what goes "wrong" when sloeber creates the platform.sloeber.txt file and look for a way to make it work without breaking something else. 😕

[Gord1]

First we need to find out what the correct content of the platform.sloeber.txt should be for your OS (I assume linux)
So I propose you modify the platform.sloeber.txt (start by adding the single quotes you already mentioned)
Save the file; go to project properties->sloeber select apply close
Check whether it is fixed.

AAH, OOH, That was MAGIC! Yes that fixed the problem!!! 🥇

Edit:
I should have added that I am using Linux, if that changes things.

[jantje]

The latest action should fix the issue.
Can you give it a try on linux (as it needed a different solution to windows)