Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento_AdvancedSearch Client Interface #3531

Open
nfourteen opened this issue Feb 18, 2025 · 0 comments
Open

Magento_AdvancedSearch Client Interface #3531

nfourteen opened this issue Feb 18, 2025 · 0 comments
Assignees
Labels

Comments

@nfourteen
Copy link

Issue

With mage-os/mageos-async-events installed, navigating to "Stores > Asynchronous Events > Logs" crashes the page with an error.

1 exception(s):
Exception #0 (RuntimeException): Search client is not set.

Exception #0 (RuntimeException): Search client is not set.
#1 Magento\Elasticsearch\SearchAdapter\ConnectionManager->getConnection() called at [vendor/mage-os/mageos-async-events/Model/Indexer/LuceneSearch.php:52]
#2 MageOS\AsyncEvents\Model\Indexer\LuceneSearch->prepare() called at [vendor/magento/framework/View/Layout/Generator/UiComponent.php:164]
#3 Magento\Framework\View\Layout\Generator\UiComponent->prepareComponent(&MageOS\AsyncEvents\Model\Indexer\LuceneSearch#000000000000065c0000000000000000#) called at [vendor/magento/framework/View/Layout/Generator/UiComponent.php:161]
...

Investigating this shows that the elasticsuite client has not been added to the \Magento\Elasticsearch\ElasticAdapter\Model\Client\ClientFactoryProxy for resolution.

Image

Question

Are there plans to implement a client that implements \Magento\AdvancedSearch\Model\Client\ClientFactoryInterface and the \Magento\AdvancedSearch\Model\Client\ClientOptionsInterface? Were there any previous attempts where issues arose?

I figured I'd open this as a question since the AsyncEvents module is using the ElasticSearch implementation directly, which appears to have a fallback in place if the opensearch engine is used. I was going to see about swapping out the implementation there and using the \Magento\AdvancedSearch\Model\Client\ClientResolver to hopefully get these two modules working together, but I'd need an implementation of the \Magento\AdvancedSearch\Model\Client\ClientFactoryInterface and the \Magento\AdvancedSearch\Model\Client\ClientOptionsInterface to wire this up.

I'm also quite new to the legacy implementation of ElasticSearch, so I may be missing something altogether on the implementation approach. 🙂

Preconditions

Magento v2.4.7-p2
Elasticsuite v2.11.10
mage-os/mageos-async-events v4.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants