From 6862dd60db6363588157efec774e585d6ce74756 Mon Sep 17 00:00:00 2001 From: Samuel M Smith Date: Thu, 21 Nov 2024 10:53:07 -0700 Subject: [PATCH] fixed bug typo in Matter Sizes some comments clean up --- src/keri/core/coring.py | 4 ++-- src/keri/core/eventing.py | 8 ++++---- src/keri/db/basing.py | 3 +++ tests/core/test_coring.py | 2 +- 4 files changed, 10 insertions(+), 7 deletions(-) diff --git a/src/keri/core/coring.py b/src/keri/core/coring.py index 99fe7e18..3230cd7f 100644 --- a/src/keri/core/coring.py +++ b/src/keri/core/coring.py @@ -298,7 +298,7 @@ class MatterCodex: Big: str = 'N' # Big 8 byte b2 number X25519_Private: str = 'O' # X25519 private decryption key/seed, may be converted from Ed25519 X25519_Cipher_Seed: str = 'P' # X25519 sealed box 124 char qb64 Cipher of 44 char qb64 Seed - ECDSA_256r1_Seed: str = "Q" # ECDSA secp256r1 256 bit random Seed for private key + ECDSA_256r1_Seed: str = 'Q' # ECDSA secp256r1 256 bit random Seed for private key Tall: str = 'R' # Tall 5 byte b2 number Large: str = 'S' # Large 11 byte b2 number Great: str = 'T' # Great 14 byte b2 number @@ -804,7 +804,7 @@ class Matter: '1AAB': Sizage(hs=4, ss=0, xs=0, fs=48, ls=0), '1AAC': Sizage(hs=4, ss=0, xs=0, fs=80, ls=0), '1AAD': Sizage(hs=4, ss=0, xs=0, fs=80, ls=0), - '1AAE': Sizage(hs=4, ss=0, xs=0, fs=56, ls=0), + '1AAE': Sizage(hs=4, ss=0, xs=0, fs=156, ls=0), '1AAF': Sizage(hs=4, ss=4, xs=0, fs=8, ls=0), '1AAG': Sizage(hs=4, ss=0, xs=0, fs=36, ls=0), '1AAH': Sizage(hs=4, ss=0, xs=0, fs=100, ls=0), diff --git a/src/keri/core/eventing.py b/src/keri/core/eventing.py index b244af68..4e1e04c5 100644 --- a/src/keri/core/eventing.py +++ b/src/keri/core/eventing.py @@ -2710,19 +2710,19 @@ def validateDelegation(self, serder, sigers, wigers, wits, delpre, *, to detect a comprimised or duplicitious superseding rotation and prevent the additional verification from proceding. - ToDo: + Mitigations of malicious source seal couples: Repair the approval source seal couple in the 'aess' database on recursive climb the kel tree. Once an event has been accepted into its kel. Later adding a source seal couple to 'aes' should then be OK from a security perspective since its only making discovery less expensive. - When malicious source seal couple is received but event is validly - delegated and the delegation source seal is repaired then need to replace + When a malicious source seal couple is received but event is validly + delegated and the delegation source seal is repaired then replace malicious source seal couple with repaired seal so repaired seal not malicous seal gets written to 'aes' db. When the event is valid but non-delegated then need to nullify malicous source seal couple so it - does not get written to 'aes' datable + does not get written to 'aes' database. """ if not delpre: # not delegable so no delegation validation needed diff --git a/src/keri/db/basing.py b/src/keri/db/basing.py index 14e9bfb5..4bfa67e3 100644 --- a/src/keri/db/basing.py +++ b/src/keri/db/basing.py @@ -1020,6 +1020,9 @@ def reopen(self, **kwa): self.udes = subing.CatCesrSuber(db=self, subkey='udes.', klas=(coring.Seqner, coring.Saider)) self.uwes = self.env.open_db(key=b'uwes.', dupsort=True) + #self.uwes = subing.CatCesrIoSetSuber(db=self, subkey='uwes.', + #klas=(coring.Saider, indexing.Siger)) + self.ooes = self.env.open_db(key=b'ooes.', dupsort=True) self.dels = self.env.open_db(key=b'dels.', dupsort=True) self.ldes = self.env.open_db(key=b'ldes.', dupsort=True) diff --git a/tests/core/test_coring.py b/tests/core/test_coring.py index e4118949..61e87e88 100644 --- a/tests/core/test_coring.py +++ b/tests/core/test_coring.py @@ -460,7 +460,7 @@ def test_matter_class(): '1AAB': Sizage(hs=4, ss=0, xs=0, fs=48, ls=0), '1AAC': Sizage(hs=4, ss=0, xs=0, fs=80, ls=0), '1AAD': Sizage(hs=4, ss=0, xs=0, fs=80, ls=0), - '1AAE': Sizage(hs=4, ss=0, xs=0, fs=56, ls=0), + '1AAE': Sizage(hs=4, ss=0, xs=0, fs=156, ls=0), '1AAF': Sizage(hs=4, ss=4, xs=0, fs=8, ls=0), '1AAG': Sizage(hs=4, ss=0, xs=0, fs=36, ls=0), '1AAH': Sizage(hs=4, ss=0, xs=0, fs=100, ls=0),