Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guzzle dependency seems to be redundant in composer.json #21

Open
nikita2206 opened this issue Sep 26, 2016 · 0 comments
Open

Guzzle dependency seems to be redundant in composer.json #21

nikita2206 opened this issue Sep 26, 2016 · 0 comments

Comments

@nikita2206
Copy link

nikita2206 commented Sep 26, 2016

After requiring monitoring-bundle in our composer.json we now have composer telling us that guzzle/guzzle is an abandoned package even though we don't use guzzle/guzzle at all:

Package guzzle/guzzle is abandoned, you should avoid using it. Use guzzlehttp/guzzle instead.

It seems like monitoring-bundle itself doesn't use guzzle as well, but it provides a plugin for it which can add RequestId to every request made with guzzle/guzzle (note it is not guzzlehttp/guzzle, which now contains a new version of guzzle).
What I'd do in this case is add guzzle/guzzle to require-dev instead of require in composer.json so that it would be available for testing monitoring-bundle, but it would be completely optional for users of this bundle.
Also it would be awesome (but out of scope of this issue) if this bundle supported bundles that integrate newer version of guzzle into Symfony, e.g.: eightpoints/guzzle-bundle, csa/guzzle-bundle and/or m6web/guzzle-http-bundle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant