Fix findNpmPathSync resolution

Author: jdalton

Diff for: src/utils/path-resolve.ts

@@ -1,4 +1,4 @@
-import { promises as fs, realpathSync, statSync } from 'node:fs'
+import { existsSync, promises as fs, realpathSync, statSync } from 'node:fs'
 import path from 'node:path'
 import process from 'node:process'
 
@@ -191,30 +191,39 @@ export function findBinPathDetailsSync(binName: string): {
 }
 
 export function findNpmPathSync(npmBinPath: string): string | undefined {
-  let curPath = npmBinPath
+  let thePath = npmBinPath
   while (true) {
+    const nmPath = path.join(thePath, NODE_MODULES)
     if (
       // npm bin paths may look like:
       // /usr/local/share/npm/bin/npm
       // /Users/SomeUsername/.nvm/versions/node/vX.X.X/bin/npm
       // C:\Users\SomeUsername\AppData\Roaming\npm\bin\npm.cmd
       // OR
       // C:\Program Files\nodejs\npm.cmd
-      path.basename(curPath) === NPM ||
+      //
       // In all cases the npm path contains a node_modules folder:
       // /usr/local/share/npm/bin/npm/node_modules
       // C:\Program Files\nodejs\node_modules
-      statSync(path.join(curPath, NODE_MODULES), {
-        throwIfNoEntry: false
-      })?.isDirectory()
+      //
+      // Use existsSync here because statsSync, even with { throwIfNoEntry: false },
+      // will throw an ENOTDIR error for paths like ./a-file-that-exists/a-directory-that-does-not.
+      // See https://github.com/nodejs/node/issues/56993.
+      existsSync(nmPath) &&
+      statSync(nmPath, { throwIfNoEntry: false })?.isDirectory() &&
+      // Optimistically look for the default location.
+      (path.basename(thePath) === NPM ||
+        // Chocolatey installs npm bins in the same directory as node bins.
+        // Lazily access constants.WIN32.
+        (constants.WIN32 && existsSync(path.join(thePath, `${NPM}.cmd`))))
     ) {
-      return curPath
+      return thePath
     }
-    const parent = path.dirname(curPath)
-    if (parent === curPath) {
+    const parent = path.dirname(thePath)
+    if (parent === thePath) {
       return undefined
     }
-    curPath = parent
+    thePath = parent
   }
 }