Skip to content

Commit 543ebcf

Browse files
committed
Fixed redundant prefixing of messages logged by the sp command.
1 parent 5176807 commit 543ebcf

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

Diff for: addons/source-python/packages/source-python/loggers.py

+6-5
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,9 @@ def _log(self, level, msg, *args, **kwargs):
233233
# Get the areas to be used
234234
areas = self.areas
235235

236+
# Get wether we should prepend prefix
237+
prepend_prefix = kwargs.pop('prepend_prefix', self.prefix is not None)
238+
236239
# Print to main log file?
237240
if MAIN_LOG & areas:
238241

@@ -249,8 +252,7 @@ def _log(self, level, msg, *args, **kwargs):
249252
message = _main_log_formatter.format(record)
250253

251254
# Prepend prefix
252-
prefix = self.prefix
253-
if prefix is not None:
255+
if prepend_prefix:
254256
message = prefix + message
255257

256258
# Print to the main log
@@ -265,9 +267,8 @@ def _log(self, level, msg, *args, **kwargs):
265267
from core import echo_console
266268

267269
# Prepend prefix
268-
prefix = self.prefix
269-
if prefix is not None:
270-
msg = prefix + msg
270+
if prepend_prefix:
271+
msg = self.prefix + msg
271272

272273
echo_console(msg)
273274

Diff for: addons/source-python/packages/source-python/plugins/command.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -269,4 +269,4 @@ def log_message(self, message):
269269
:param str message:
270270
Message to log.
271271
"""
272-
self.logger.log_message(self.prefix + message)
272+
self.logger.log_message(self.prefix + message, prepend_prefix=False)

0 commit comments

Comments
 (0)