Remove all subtick moves instead of zeroing them

Also update detour definition as it's actually a controller that's passed, which makes more sense

Author: xen-000

src/detours.cpp

@@ -487,27 +487,20 @@ class CUserCmd
 #endif
 };
 
-void* FASTCALL Detour_ProcessUsercmds(CBasePlayerPawn *pPawn, CUserCmd *cmds, int numcmds, bool paused, float margin)
+void* FASTCALL Detour_ProcessUsercmds(CCSPlayerController *pController, CUserCmd *cmds, int numcmds, bool paused, float margin)
 {
 	// Push fix only works properly if subtick movement is also disabled
 	if (!g_bDisableSubtick && !g_bUseOldPush)
-		return ProcessUsercmds(pPawn, cmds, numcmds, paused, margin);
+		return ProcessUsercmds(pController, cmds, numcmds, paused, margin);
 
 	VPROF_SCOPE_BEGIN("Detour_ProcessUsercmds");
 
-	static int offset = g_GameConfig->GetOffset("UsercmdOffset");
-
 	for (int i = 0; i < numcmds; i++)
-	{
-		CSGOUserCmdPB *pUserCmd = &cmds[i].cmd;
-
-		for (int j = 0; j < pUserCmd->mutable_base()->subtick_moves_size(); j++)
-			pUserCmd->mutable_base()->mutable_subtick_moves(j)->set_when(0.f);
-	}
+		cmds[i].cmd.mutable_base()->mutable_subtick_moves()->Clear();
 
 	VPROF_SCOPE_END();
 
-	return ProcessUsercmds(pPawn, cmds, numcmds, paused, margin);
+	return ProcessUsercmds(pController, cmds, numcmds, paused, margin);
 }
 
 void FASTCALL Detour_CGamePlayerEquip_InputTriggerForAllPlayers(CGamePlayerEquip* pEntity, InputData_t* pInput)

src/detours.h

@@ -60,7 +60,7 @@ bool FASTCALL Detour_CCSPlayer_WeaponServices_CanUse(CCSPlayer_WeaponServices *,
 bool FASTCALL Detour_CEntityIdentity_AcceptInput(CEntityIdentity* pThis, CUtlSymbolLarge* pInputName, CEntityInstance* pActivator, CEntityInstance* pCaller, variant_t* value, int nOutputID);
 void* FASTCALL Detour_CNavMesh_GetNearestNavArea(int64_t unk1, float* unk2, unsigned int* unk3, unsigned int unk4, int64_t unk5, int64_t unk6, float unk7, int64_t unk8);
 void FASTCALL Detour_ProcessMovement(CCSPlayer_MovementServices *pThis, void *pMove);
-void *FASTCALL Detour_ProcessUsercmds(CBasePlayerPawn *pawn, CUserCmd *cmds, int numcmds, bool paused, float margin);
+void *FASTCALL Detour_ProcessUsercmds(CCSPlayerController *pController, CUserCmd *cmds, int numcmds, bool paused, float margin);
 void FASTCALL  Detour_CGamePlayerEquip_InputTriggerForAllPlayers(CGamePlayerEquip*, InputData_t*);
 void FASTCALL  Detour_CGamePlayerEquip_InputTriggerForActivatedPlayer(CGamePlayerEquip*, InputData_t*);
 int64_t* FASTCALL Detour_CCSGameRules_GoToIntermission(int64_t unk1, char unk2);