Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Link checker in pipeline #602

Closed
cah-hbaum opened this issue May 23, 2024 · 4 comments · Fixed by #659
Closed

[Feature Request] Link checker in pipeline #602

cah-hbaum opened this issue May 23, 2024 · 4 comments · Fixed by #659
Assignees
Labels
enhancement New feature or request SCS is continuously built and tested SCS is continuously built and tested in order to raise velocity and quality SCS-VP10 Related to tender lot SCS-VP10
Milestone

Comments

@cah-hbaum
Copy link
Contributor

Coming from this PR and this issue, @artificial-intelligence suggested that we should probably include a link checker to combat potential Link Rot in our standard documents.

@cah-hbaum cah-hbaum added enhancement New feature or request SCS is continuously built and tested SCS is continuously built and tested in order to raise velocity and quality labels May 23, 2024
@mbuechse mbuechse added the SCS-VP10 Related to tender lot SCS-VP10 label May 24, 2024
@mbuechse mbuechse added this to the R7 (v8.0.0) milestone May 24, 2024
@mbuechse
Copy link
Contributor

@martinmo martinmo self-assigned this May 27, 2024
@artificial-intelligence
Copy link
Contributor

I also have implemented something similar before, you might want to check osism/osism.github.io@3b5cf94 (it's similar to the above solution posted)

@martinmo
Copy link
Member

We already have https://github.com/SovereignCloudStack/standards/blob/main/.github/workflows/link-validator.yml, which even runs on a regular schedule.

Maybe it is a configuration issue: check-modified-files-only: 'yes' is set unconditionally, but for the scheduled runs this doesn't make sense.

@martinmo
Copy link
Member

Yes, if I compare a scheduled run vs. a run triggered by push, the scheduled run is missing this

From https://github.com/SovereignCloudStack/standards
 * branch            main       -> FETCH_HEAD
 * [new branch]      main       -> origin/main
=========================> MARKDOWN LINK CHECK <=========================

[✔] All links are good!

=========================================================================

and instead just prints

From https://github.com/SovereignCloudStack/standards
 * branch            main       -> FETCH_HEAD
All good!

which makes me think nothing is checked at all in this case.

(Unfortunately it doesn't show more details, e.g., number of files checked.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request SCS is continuously built and tested SCS is continuously built and tested in order to raise velocity and quality SCS-VP10 Related to tender lot SCS-VP10
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants