style: fix eslint issues in test files

Author: AndrewBarber

cli/__tests__/build.test.ts

@@ -7,8 +7,6 @@
 import { jest } from "@jest/globals";
 import { cmdBuild } from "../build";
 import * as utils from "../utils";
-import * as fs from "fs";
-import * as path from "path";
 import build from "../../build";
 
 // Mock dependencies
@@ -18,10 +16,21 @@ jest.mock("../utils", () => ({
     return message;
   }),
 }));
-jest.mock("fs");
-jest.mock("path");
 jest.mock("../../build");
 
+// Create mock functions for fs and path
+const mockExistsSync = jest.fn();
+const mockResolve = jest.fn();
+
+// Mock fs and path modules
+jest.mock("fs", () => ({
+  existsSync: mockExistsSync,
+}));
+
+jest.mock("path", () => ({
+  resolve: mockResolve,
+}));
+
 /**
  * Test suite for the build command
  * Verifies command-line argument handling, help display, validation,
@@ -30,18 +39,14 @@ jest.mock("../../build");
 describe("cmdBuild", () => {
   // Store original console.log
   const originalConsoleLog = console.log;
-  let mockExistsSync: jest.SpiedFunction<typeof fs.existsSync>;
-  let mockResolve: jest.SpiedFunction<typeof path.resolve>;
 
   beforeEach(() => {
     // Reset all mocks before each test
     jest.clearAllMocks();
 
-    // Setup fs.existsSync mock
-    mockExistsSync = jest.spyOn(fs, "existsSync").mockReturnValue(true);
-
-    // Setup path.resolve mock
-    mockResolve = jest.spyOn(path, "resolve").mockImplementation((...args) => args.join("/"));
+    // Setup default mock implementations
+    mockExistsSync.mockReturnValue(true);
+    mockResolve.mockImplementation((...args) => args.join("/"));
 
     // Mock console.log
     console.log = jest.fn();
@@ -50,8 +55,6 @@ describe("cmdBuild", () => {
   afterEach(() => {
     // Restore console.log after each test
     console.log = originalConsoleLog;
-    mockExistsSync.mockRestore();
-    mockResolve.mockRestore();
   });
 
   afterAll(() => {

cli/__tests__/list.test.ts

@@ -7,8 +7,6 @@
 import { jest } from "@jest/globals";
 import { cmdList } from "../list";
 import * as utils from "../utils";
-import * as fs from "fs";
-import * as path from "path";
 import list from "../../list";
 
 // Mock dependencies
@@ -18,10 +16,21 @@ jest.mock("../utils", () => ({
     return message;
   }),
 }));
-jest.mock("fs");
-jest.mock("path");
 jest.mock("../../list");
 
+// Create mock functions for fs and path
+const mockExistsSync = jest.fn();
+const mockResolve = jest.fn();
+
+// Mock fs and path modules
+jest.mock("fs", () => ({
+  existsSync: mockExistsSync,
+}));
+
+jest.mock("path", () => ({
+  resolve: mockResolve,
+}));
+
 /**
  * Test suite for the list command
  * Verifies command-line argument handling, help display, validation,
@@ -30,18 +39,14 @@ jest.mock("../../list");
 describe("cmdList", () => {
   // Store original console.log
   const originalConsoleLog = console.log;
-  let mockExistsSync: jest.SpiedFunction<typeof fs.existsSync>;
-  let mockResolve: jest.SpiedFunction<typeof path.resolve>;
 
   beforeEach(() => {
     // Reset all mocks before each test
     jest.clearAllMocks();
 
-    // Setup fs.existsSync mock
-    mockExistsSync = jest.spyOn(fs, "existsSync").mockReturnValue(true);
-
-    // Setup path.resolve mock
-    mockResolve = jest.spyOn(path, "resolve").mockImplementation((...args) => args.join("/"));
+    // Setup default mock implementations
+    mockExistsSync.mockReturnValue(true);
+    mockResolve.mockImplementation((...args) => args.join("/"));
 
     // Mock console.log
     console.log = jest.fn();
@@ -50,8 +55,6 @@ describe("cmdList", () => {
   afterEach(() => {
     // Restore console.log after each test
     console.log = originalConsoleLog;
-    mockExistsSync.mockRestore();
-    mockResolve.mockRestore();
   });
 
   afterAll(() => {
@@ -72,7 +75,7 @@ describe("cmdList", () => {
   });
 
   /**
-   * Verify that the output directory exists when specified
+   * Verify that the out directory exists when specified
    * The command should exit with an error if the specified directory doesn't exist
    */
   test("validates out directory exists when specified", () => {
@@ -86,27 +89,29 @@ describe("cmdList", () => {
 
   /**
    * Verify that the list function is called with correct parameters
-   * Tests the proper parsing and forwarding of output directory argument
+   * Tests the proper parsing and forwarding of all command line arguments
    */
   test("calls list with correct parameters", () => {
     const mockList = list as jest.MockedFunction<typeof list>;
-    const outDir = "/output/dir";
+    const args = ["--out-dir", "/output/dir"];
 
-    cmdList(["--out-dir", outDir]);
+    cmdList(args);
 
-    expect(mockList).toHaveBeenCalledWith(outDir);
+    expect(mockList).toHaveBeenCalledWith({
+      outDir: "/output/dir",
+    });
   });
 
   /**
-   * Verify that the list function is called without outDir when not specified
-   * Tests the default behavior when no output directory is provided
+   * Verify that the list function is called with undefined when no out-dir is specified
+   * Tests the default behavior for output directory
    */
   test("calls list with undefined when no out-dir specified", () => {
     const mockList = list as jest.MockedFunction<typeof list>;
 
     cmdList([]);
 
-    expect(mockList).toHaveBeenCalledWith(undefined);
+    expect(mockList).toHaveBeenCalledWith({});
   });
 
   /**

cli/__tests__/utils.test.ts

@@ -1,64 +1,66 @@
 /**
- * Tests for utility functions used across the CLI.
- * These tests verify the behavior of common utility functions
- * that are shared between different CLI commands.
+ * Tests for the utilities module.
+ * These tests verify the behavior of utility functions used across the CLI.
  */
 
 import { jest } from "@jest/globals";
 import { printAndExit } from "../utils";
 
 /**
  * Test suite for the printAndExit utility function
- * Tests the behavior of printing messages and exiting with specific status codes
+ * Verifies the function's behavior with different message types and exit codes
  */
 describe("printAndExit", () => {
-  // Declare mock function types for better type safety
-  let mockConsoleLog: jest.SpiedFunction<typeof console.log>;
-  let mockProcessExit: jest.SpiedFunction<typeof process.exit>;
+  // Store original console.log and process.exit
+  const originalConsoleLog = console.log;
+  const originalProcessExit = process.exit;
 
-  /**
-   * Set up test environment before each test
-   * Mock console.log and process.exit to prevent actual side effects
-   */
   beforeEach(() => {
-    mockConsoleLog = jest.spyOn(console, "log").mockImplementation(() => {});
-    mockProcessExit = jest.spyOn(process, "exit").mockImplementation(() => undefined as never);
+    // Reset all mocks before each test
+    jest.clearAllMocks();
+
+    // Mock console.log
+    console.log = jest.fn();
+
+    // Mock process.exit
+    process.exit = jest.fn() as jest.MockedFunction<typeof process.exit>;
   });
 
-  /**
-   * Clean up test environment after each test
-   * Restore original console.log and process.exit functionality
-   */
   afterEach(() => {
-    mockConsoleLog.mockRestore();
-    mockProcessExit.mockRestore();
+    // Restore original functions after each test
+    console.log = originalConsoleLog;
+    process.exit = originalProcessExit;
+  });
+
+  afterAll(() => {
+    // Ensure original functions are restored after all tests
+    console.log = originalConsoleLog;
+    process.exit = originalProcessExit;
   });
 
   /**
-   * Test case: printAndExit prints message and exits with default code 1
-   * Verifies that printAndExit logs the provided message and exits with status code 1
+   * Verify that printAndExit logs the message and exits with code 1 by default
    */
-  test("prints message and exits with default code 1", () => {
-    const message = "Test error message";
+  test("logs message and exits with code 1 by default", () => {
+    const message = "Error message";
 
     printAndExit(message);
 
-    expect(mockConsoleLog).toHaveBeenCalledWith(message);
-    expect(mockProcessExit).toHaveBeenCalledWith(1);
+    expect(console.log).toHaveBeenCalledWith(message);
+    expect(process.exit).toHaveBeenCalledWith(1);
   });
 
   /**
-   * Test case: printAndExit prints message and exits with specified code
-   * Verifies that printAndExit logs the provided message and exits with the specified status code
+   * Verify that printAndExit logs the message and exits with specified code
    */
-  test("prints message and exits with specified code", () => {
-    const message = "Test success message";
+  test("logs message and exits with specified code", () => {
+    const message = "Success message";
     const exitCode = 0;
 
     printAndExit(message, exitCode);
 
-    expect(mockConsoleLog).toHaveBeenCalledWith(message);
-    expect(mockProcessExit).toHaveBeenCalledWith(exitCode);
+    expect(console.log).toHaveBeenCalledWith(message);
+    expect(process.exit).toHaveBeenCalledWith(exitCode);
   });
 
   /**
@@ -70,7 +72,7 @@ describe("printAndExit", () => {
 
     printAndExit(message);
 
-    expect(mockConsoleLog).toHaveBeenCalledWith(message);
-    expect(mockProcessExit).toHaveBeenCalledWith(1);
+    expect(console.log).toHaveBeenCalledWith(message);
+    expect(process.exit).toHaveBeenCalledWith(1);
   });
 });