Skip to content

Commit 6f19541

Browse files
committed
project: Add c8, switch to it in CI/CD.
Since coverage support is experimental in Node.js and CodeCov seem to have trouble interpreting it, plus I am unsure whenever Node.js actually generates a valid coverage file, use `c8` instead for the time being. I switch to Node once it stabilizes and docs will claim this is ready to be used in production.
1 parent fa298c7 commit 6f19541

File tree

4 files changed

+496
-8
lines changed

4 files changed

+496
-8
lines changed

Diff for: .github/workflows/node-test.yml

+2-7
Original file line numberDiff line numberDiff line change
@@ -27,20 +27,15 @@ jobs:
2727
run: "npm run build"
2828
- name: Run tests with coverage+test reporting
2929
run: |
30-
npm test -- --experimental-test-coverage \
31-
--test-reporter=lcov --test-reporter-destination=lcov.info \
30+
npm run test:coverage -- --experimental-test-coverage \
3231
--test-reporter=spec --test-reporter-destination=stdout \
3332
--test-reporter=junit --test-reporter-destination=junit.xml
3433
- name: Upload coverage reports to Codecov
3534
uses: codecov/codecov-action@v5
3635
with:
3736
token: ${{ secrets.CODECOV_TOKEN }}
38-
disable_search: true
39-
files: lcov.info
4037
- name: Upload test results to CodeCov
4138
if: ${{ !cancelled() }}
4239
uses: codecov/test-results-action@v1
4340
with:
44-
token: ${{ secrets.CODECOV_TOKEN }}
45-
disable_search: true
46-
file: junit.xml
41+
token: ${{ secrets.CODECOV_TOKEN }}

Diff for: makers/appimage/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
"main": "dist/main.js",
77
"scripts": {
88
"prepack": "tsc",
9-
"test": "tsc -b tsconfig.test.json && NODE_NO_WARNINGS=1 node --test --experimental-strip-types"
9+
"test": "tsc -b tsconfig.test.json && NODE_NO_WARNINGS=1 node --test --experimental-strip-types",
10+
"test:coverage": "c8 -r json npm test --"
1011
},
1112
"repository": {
1213
"type": "git",

0 commit comments

Comments
 (0)