Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to type2runtime by default from old AppImageKit runtimes. #17

Open
Drsheppard01 opened this issue Jan 28, 2025 · 5 comments
Open
Labels
📦️ package:maker-appimage Associated to @reforged/maker-appimage 🏷️ type:feat New feature or request

Comments

@Drsheppard01
Copy link

Please switch to the new version at
https://github.com/AppImage/appimagetool/releases/tag/continuous
This version is merely kept around for legacy compatibility. It is not recommended to be used anymore and is no longer actively supported.

@SpacingBat3
Copy link
Owner

SpacingBat3 commented Jan 28, 2025

We don't need to move into anything, only change the defaults. Technically, there's type2runtime config property that basically makes it to use the same runtime as new appimagetool. And ReForged principles are not to rely on toolkits made specifically to package to the specific format if possible, and rather handle packaging on its own from scratch. Thus, maker-appimage is kinda appimagetool reimplementation in JavaScript on its own, only relying on system-wide mksquashfs.

@Drsheppard01
Copy link
Author

If this is true, is it possible to use type2-runtime by default instead of optional?

@Drsheppard01

This comment has been minimized.

@SpacingBat3
Copy link
Owner

If this is true, is it possible to use type2-runtime by default instead of optional?

Sure, I'll probably also consider a bit different runtime source management (there's way more runtimes in the internet, and even some alternatives to AppImages that aim to become cross-platform) and possibly to drop AppRun entirely, I think symlink to bin is enough for Electron apps anyway. The problem are still hash checks, since those ReForged had hard-coded before and with the continuous release cycle, it'll be troublesome to keep it that way… I mean, I can always rely on checksums and error corrections within the protocols entirely.

@SpacingBat3 SpacingBat3 linked a pull request Jan 28, 2025 that will close this issue
@SpacingBat3 SpacingBat3 added 🏷️ type:feat New feature or request 📦️ package:maker-appimage Associated to @reforged/maker-appimage labels Jan 28, 2025
@SpacingBat3 SpacingBat3 changed the title appimagetool instead appimagekit Switch to type2runtime by default from old AppImageKit runtimes. Jan 28, 2025
@Drsheppard01
Copy link
Author

Now I'm looking forward to the release. I'm sure it will help the whole community. Thank you for your contribution to the AppImage ecosystem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦️ package:maker-appimage Associated to @reforged/maker-appimage 🏷️ type:feat New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants