Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidebar.on("hide") No Longer Applies to Server Sidebar #580

Open
2 of 7 tasks
a-priestley opened this issue Jan 16, 2025 · 3 comments
Open
2 of 7 tasks

sidebar.on("hide") No Longer Applies to Server Sidebar #580

a-priestley opened this issue Jan 16, 2025 · 3 comments
Assignees
Labels
type:bug Something isn't working

Comments

@a-priestley
Copy link

Acknowledgements

  • I have checked that there is no other issue describing the same or
    similar problem that I currently have, regardless if it has been
    closed or open.

  • This bug affects Discord website.

  • This issue is confirmed to be reproducible when WebCord is packaged
    on at least all three latest supported Electron major releases.

  • This issue is reproducible in Chrome, Chromium or any
    Chromium-based browser, e.g Brave or Edge (please write in
    Additional Context which browser you have used if it is neither
    Chrome nor unmodified Chromium).

  • There are no fixes done to master which resolves this issue.

  • My issue describes one of the unstable and/or not fully implemented
    features.

  • I have found a workaround to mitigate or temporarily fix this issue
    in affected releases (please write it in Additional context section
    below).

Operating System / Platform

🐧️ Linux

Operating system architecture

x64 (64-bit Intel/AMD)

Electron version

v33.3.1

Application version

v4.10.3

Bug description

Using the sidebar hiding functionality no longer appears to work on the main server sidebar. The injected style is being overruled by another applying to the same element:

Image

Related: What is the .visual-refresh property for the main html element. Something the discord devs are working on currently? If I add it to the class list the layout and style change dramatically, but it doesn't seem like it's done yet.

Additional context

No response

@a-priestley a-priestley added the type:bug Something isn't working label Jan 16, 2025
@SpacingBat3
Copy link
Owner

SpacingBat3 commented Jan 17, 2025

Have you tried temporarily adding the .hidden_* class? I have a gut feeling Discord might actually implement sidebar hiding on their own, but I need to test it later myself.

@a-priestley
Copy link
Author

Have you tried temporarily adding the .hidden_* class? I have a gut feeling Discord might actually implement sidebar hiding on their own, but I need to test it later myself.

Yes this does work!:

Image

There's no animation though.

@SpacingBat3
Copy link
Owner

I think Discord's going to add some sidebar hiding feature, or maybe already added for some platforms / user agent (namely Android). I wasn't really researching it for some time, at least deeply in-code…

I'm not sure I want to fight against their styling if some stuff are yet to come, but I might check as well the CSS injection priorities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants