Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP files are written in public directory #142

Open
integratedforpublishers opened this issue Apr 26, 2017 · 0 comments
Open

PHP files are written in public directory #142

integratedforpublishers opened this issue Apr 26, 2017 · 0 comments

Comments

@integratedforpublishers

Some Bower supporting repositories contain PHP files. For example the jQuery repo contains some PHP test files:
https://github.com/jquery/jquery/tree/master/test/data

In the default configuration the assets:install will copy the full components directory to a public path (like web/bundles/app/components), including the PHP files, making them available to the public.

The jQuery files do not seem to be very dangerous, but some repos will install a file uploader into your public area:
https://github.com/blueimp/jQuery-File-Upload/tree/master/server/php

I think these files should either be stripped from the bundle components folder, or not installed in the public folder. I think it should be possible to configure the safe extensions, because they might be different per bundle or project.

Also the "ignore" section of bower.json files is ignored. Filtering these field would help, but is not 100% as it isn't configured correctly in every repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant