Skip to content

hatchling build broke pypi wheel #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alejoe91 opened this issue May 5, 2025 · 3 comments · Fixed by #343
Closed

hatchling build broke pypi wheel #342

alejoe91 opened this issue May 5, 2025 · 3 comments · Fixed by #343

Comments

@alejoe91
Copy link
Member

alejoe91 commented May 5, 2025

@h-mayorquin

I think that #335 broke pypi packaging. After installing the latest just released version I get a probeinterface not found.

And in fact, the shipped whl doesn't contain anything meaningful. I'll try to find a solution

@h-mayorquin
Copy link
Collaborator

h-mayorquin commented May 5, 2025

Thanks for fixing this. That's strange that this was not captured by the the full tests which install the latest version. Maybe this is related to the fact that we test editable and that's why the error was not catched?

@alejoe91
Copy link
Member Author

alejoe91 commented May 5, 2025

Yes indeed. The problem was just in packaging the wheel. I added a step in the publish to pypi action to install from the newly generated wheel and import the package

@h-mayorquin
Copy link
Collaborator

Here, maybe this will help to detect other errors in the future anyway:

#348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants