Skip to content

Commit 4f6b702

Browse files
authored
Merge pull request #15 from SpringRoll/bug/fix-incorrect-array-method-calls
Correct all forEach
2 parents 9ee1270 + 0302bb0 commit 4f6b702

File tree

3 files changed

+37
-53
lines changed

3 files changed

+37
-53
lines changed

dist/container.js

Lines changed: 18 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -2611,10 +2611,9 @@
26112611

26122612
this.onPauseToggle = onPauseToggle.bind(this);
26132613

2614-
this.pauseButton.forEach(function(element)
2615-
{
2616-
element.addEventListener('click', this.onPauseToggle);
2617-
}.bind(this));
2614+
for(var i = 0; i < this.pauseButton.length; i++){
2615+
this.pauseButton[i].addEventListener('click', this.onPauseToggle);
2616+
}
26182617

26192618
/**
26202619
* If the application is currently paused manually
@@ -2674,15 +2673,12 @@
26742673
this.trigger('pause', paused);
26752674

26762675
// Set the pause button state
2677-
this.pauseButton.forEach(
2678-
function(element)
2679-
{
2680-
element.classList.remove('unpaused');
2681-
element.classList.remove('paused');
2682-
2683-
element.classList.add(paused ? 'paused' : 'unpaused');
2684-
}.bind(this)
2685-
);
2676+
for(var i = 0; i < this.pauseButton.length; i++){
2677+
var element = this.pauseButton[i];
2678+
element.classList.remove('unpaused');
2679+
element.classList.remove('paused');
2680+
element.classList.add(paused ? 'paused' : 'unpaused');
2681+
}
26862682
}
26872683
},
26882684
get: function()
@@ -2713,31 +2709,27 @@
27132709

27142710
plugin.opened = function()
27152711
{
2716-
this.pauseButton.forEach(
2717-
function(element)
2718-
{
2719-
element.classList.remove('disabled');
2720-
}.bind(this)
2721-
);
2712+
for(var i = 0; i < this.pauseButton.length; i++){
2713+
this.pauseButton[i].classList.remove('disabled');
2714+
}
27222715

27232716
// Reset the paused state
27242717
this.paused = this._paused;
27252718
};
27262719

27272720
plugin.close = function()
27282721
{
2729-
this.pauseButton.forEach(this._disableButton.bind(this));
2722+
for(var i = 0; i < this.pauseButton.length; i++){
2723+
this._disableButton.bind(this.pauseButton[i]);
2724+
}
27302725
this.paused = false;
27312726
};
27322727

27332728
plugin.teardown = function()
27342729
{
2735-
this.pauseButton.forEach(
2736-
function(element)
2737-
{
2738-
element.removeEventListener('click', this.onPauseToggle);
2739-
}.bind(this)
2740-
);
2730+
for(var i = 0; i < this.pauseButton.length; i++){
2731+
this.pauseButton[i].removeEventListener('click', this.onPauseToggle);
2732+
}
27412733
delete this.pauseButton;
27422734
delete this._isManualPause;
27432735
delete this._paused;

0 commit comments

Comments
 (0)