Skip to content

Commit 640c473

Browse files
authored
Merge pull request #182 from SpringRoll/bugfix/187407393_captions_persistance
Bugfix/187407393 captions persistance
2 parents 51bfaee + 747ec3b commit 640c473

8 files changed

+39
-40
lines changed

Diff for: CHANGELOG.md

+6
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [2.5.2] - unreleased
9+
10+
### Fixed
11+
12+
- Ensured that CaptionsTogglePlugin internal state is maintained when reading from localStorage on startup
13+
814
## [2.5.1] - 2024-04-16
915

1016
### Fixed

Diff for: dist/SpringRoll-Container-umd.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: dist/SpringRoll-Container-umd.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: dist/index.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: dist/index.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: package-lock.json

+25-31
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,10 @@
2929
"karma-babel-preprocessor": "^8.0.0",
3030
"karma-browserstack-launcher": "^1.5.1",
3131
"karma-chai": "^0.1.0",
32-
"karma-chrome-launcher": "^2.2.0",
32+
"karma-chrome-launcher": "^3.2.0",
3333
"karma-cli": "^2.0.0",
3434
"karma-es6-shim": "^1.0.0",
35-
"karma-firefox-launcher": "^1.1.0",
35+
"karma-firefox-launcher": "^2.1.3",
3636
"karma-html": "^1.0.5",
3737
"karma-mocha": "^2.0.1",
3838
"karma-requirejs": "^1.1.0",

Diff for: src/plugins/CaptionsTogglePlugin.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,8 @@ export class CaptionsTogglePlugin extends ButtonPlugin {
6565
return;
6666
}
6767

68-
const captionsMuted = !!SavedData.read(CaptionsTogglePlugin.captionsToggleKey);
69-
70-
this._setMuteProp('captionsMuted', this._captionsButtons, captionsMuted, true);
68+
this._captionsMuted = !!SavedData.read(CaptionsTogglePlugin.captionsToggleKey);
69+
this._setMuteProp('captionsMuted', this._captionsButtons, this._captionsMuted, true);
7170

7271
}.bind(this)
7372
);

0 commit comments

Comments
 (0)