Merge pull request #182 from SpringRoll/bugfix/187407393_captions_per…

…sistance Bugfix/187407393 captions persistance
SpringRoll · Jun 5, 2024 · 640c473 · 640c473
2 parents 51bfaee + 747ec3b
commit 640c473
Show file tree

Hide file tree

Showing 8 changed files with 39 additions and 40 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.5.2] - unreleased
+
+### Fixed
+
+- Ensured that CaptionsTogglePlugin internal state is maintained when reading from localStorage on startup 
+
 ## [2.5.1] - 2024-04-16
 
 ### Fixed

diff --git a/dist/SpringRoll-Container-umd.js b/dist/SpringRoll-Container-umd.js
diff --git a/dist/SpringRoll-Container-umd.js.map b/dist/SpringRoll-Container-umd.js.map
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -29,10 +29,10 @@
     "karma-babel-preprocessor": "^8.0.0",
     "karma-browserstack-launcher": "^1.5.1",
     "karma-chai": "^0.1.0",
-    "karma-chrome-launcher": "^2.2.0",
+    "karma-chrome-launcher": "^3.2.0",
     "karma-cli": "^2.0.0",
     "karma-es6-shim": "^1.0.0",
-    "karma-firefox-launcher": "^1.1.0",
+    "karma-firefox-launcher": "^2.1.3",
     "karma-html": "^1.0.5",
     "karma-mocha": "^2.0.1",
     "karma-requirejs": "^1.1.0",

diff --git a/src/plugins/CaptionsTogglePlugin.js b/src/plugins/CaptionsTogglePlugin.js
@@ -65,9 +65,8 @@ export class CaptionsTogglePlugin extends ButtonPlugin {
           return;
         }
 
-        const captionsMuted = !!SavedData.read(CaptionsTogglePlugin.captionsToggleKey);
-
-        this._setMuteProp('captionsMuted', this._captionsButtons, captionsMuted, true);
+        this._captionsMuted = !!SavedData.read(CaptionsTogglePlugin.captionsToggleKey);
+        this._setMuteProp('captionsMuted', this._captionsButtons, this._captionsMuted, true);
 
       }.bind(this)
     );