Skip to content

Commit 9142fc7

Browse files
author
Antoinette C. Janus
committed
Converted array prototype to for loops
1 parent c1d424e commit 9142fc7

File tree

2 files changed

+36
-63
lines changed

2 files changed

+36
-63
lines changed

dist/container.js

Lines changed: 18 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -2611,13 +2611,9 @@
26112611

26122612
this.onPauseToggle = onPauseToggle.bind(this);
26132613

2614-
Array.prototype.forEach.call(
2615-
this.pauseButton,
2616-
function(element)
2617-
{
2618-
element.addEventListener('click', this.onPauseToggle);
2619-
}.bind(this)
2620-
);
2614+
for(var i = 0; i < this.pauseButton.length; i++){
2615+
this.pauseButton[i].addEventListener('click', this.onPauseToggle);
2616+
}
26212617

26222618
/**
26232619
* If the application is currently paused manually
@@ -2677,16 +2673,12 @@
26772673
this.trigger('pause', paused);
26782674

26792675
// Set the pause button state
2680-
Array.prototype.forEach.call(
2681-
this.pauseButton,
2682-
function(element)
2683-
{
2684-
element.classList.remove('unpaused');
2685-
element.classList.remove('paused');
2686-
2687-
element.classList.add(paused ? 'paused' : 'unpaused');
2688-
}.bind(this)
2689-
);
2676+
for(var i = 0; i < this.pauseButton.length; i++){
2677+
var element = this.pauseButton[i];
2678+
element.classList.remove('unpaused');
2679+
element.classList.remove('paused');
2680+
element.classList.add(paused ? 'paused' : 'unpaused');
2681+
}
26902682
}
26912683
},
26922684
get: function()
@@ -2717,33 +2709,27 @@
27172709

27182710
plugin.opened = function()
27192711
{
2720-
Array.prototype.forEach.call(
2721-
this.pauseButton,
2722-
function(element)
2723-
{
2724-
element.classList.remove('disabled');
2725-
}.bind(this)
2726-
);
2712+
for(var i = 0; i < this.pauseButton.length; i++){
2713+
this.pauseButton[i].classList.remove('disabled');
2714+
}
27272715

27282716
// Reset the paused state
27292717
this.paused = this._paused;
27302718
};
27312719

27322720
plugin.close = function()
27332721
{
2734-
Array.prototype.forEach.call(this.pauseButton, this._disableButton.bind(this));
2722+
for(var i = 0; i < this.pauseButton.length; i++){
2723+
this._disableButton.bind(this.pauseButton[i]);
2724+
}
27352725
this.paused = false;
27362726
};
27372727

27382728
plugin.teardown = function()
27392729
{
2740-
Array.prototype.forEach.call(
2741-
this.pauseButton,
2742-
function(element)
2743-
{
2744-
element.removeEventListener('click', this.onPauseToggle);
2745-
}.bind(this)
2746-
);
2730+
for(var i = 0; i < this.pauseButton.length; i++){
2731+
this.pauseButton[i].removeEventListener('click', this.onPauseToggle);
2732+
}
27472733
delete this.pauseButton;
27482734
delete this._isManualPause;
27492735
delete this._paused;

src/container/plugins/PausePlugin.js

Lines changed: 18 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,9 @@
1919

2020
this.onPauseToggle = onPauseToggle.bind(this);
2121

22-
Array.prototype.forEach.call(
23-
this.pauseButton,
24-
function(element)
25-
{
26-
element.addEventListener('click', this.onPauseToggle);
27-
}.bind(this));
22+
for(var i = 0; i < this.pauseButton.length; i++){
23+
this.pauseButton[i].addEventListener('click', this.onPauseToggle).bind(this);
24+
}
2825

2926
/**
3027
* If the application is currently paused manually
@@ -84,16 +81,12 @@
8481
this.trigger('pause', paused);
8582

8683
// Set the pause button state
87-
Array.prototype.forEach.call(
88-
this.pauseButton,
89-
function(element)
90-
{
91-
element.classList.remove('unpaused');
92-
element.classList.remove('paused');
93-
94-
element.classList.add(paused ? 'paused' : 'unpaused');
95-
}.bind(this)
96-
);
84+
for(var i = 0; i < this.pauseButton.length; i++){
85+
var element = this.pauseButton[i];
86+
element.classList.remove('unpaused');
87+
element.classList.remove('paused');
88+
element.classList.add(paused ? 'paused' : 'unpaused');
89+
}
9790
}
9891
},
9992
get: function()
@@ -124,33 +117,27 @@
124117

125118
plugin.opened = function()
126119
{
127-
Array.prototype.forEach.call(
128-
this.pauseButton,
129-
function(element)
130-
{
131-
element.classList.remove('disabled');
132-
}.bind(this)
133-
);
120+
for(var i = 0; i < this.pauseButton.length; i++){
121+
this.pauseButton[i].classList.remove('disabled');
122+
}
134123

135124
// Reset the paused state
136125
this.paused = this._paused;
137126
};
138127

139128
plugin.close = function()
140129
{
141-
Array.prototype.forEach.call(this.pauseButton, this._disableButton.bind(this));
130+
for(var i = 0; i < this.pauseButton.length; i++){
131+
this._disableButton.bind(this.pauseButton[i]);
132+
}
142133
this.paused = false;
143134
};
144135

145136
plugin.teardown = function()
146137
{
147-
Array.prototype.forEach.call(
148-
this.pauseButton,
149-
function(element)
150-
{
151-
element.removeEventListener('click', this.onPauseToggle);
152-
}.bind(this)
153-
);
138+
for(var i = 0; i < this.pauseButton.length; i++){
139+
this.pauseButton[i].removeEventListener('click', this.onPauseToggle);
140+
}
154141
delete this.pauseButton;
155142
delete this._isManualPause;
156143
delete this._paused;

0 commit comments

Comments
 (0)