Tolerate jar files with no manifest in ChangeableUrls

Closes spring-projectsgh-5704

Author: wilkinsona

spring-boot-devtools/src/main/java/org/springframework/boot/devtools/restart/ChangeableUrls.java

@@ -119,19 +119,23 @@ private static JarFile getJarFileIfPossible(URL url) {
 	}
 
 	private static List<URL> getUrlsFromClassPathAttribute(URL base, Manifest manifest) {
-		List<URL> urls = new ArrayList<URL>();
+		if (manifest == null) {
+			return Collections.<URL>emptyList();
+		}
 		String classPathAttribute = manifest.getMainAttributes()
 				.getValue(Attributes.Name.CLASS_PATH);
-		if (StringUtils.hasText(classPathAttribute)) {
-			for (String entry : StringUtils.delimitedListToStringArray(classPathAttribute,
-					" ")) {
-				try {
-					urls.add(new URL(base, entry));
-				}
-				catch (MalformedURLException ex) {
-					throw new IllegalStateException(
-							"Class-Path attribute contains malformed URL", ex);
-				}
+		if (!StringUtils.hasText(classPathAttribute)) {
+			return Collections.<URL>emptyList();
+		}
+		List<URL> urls = new ArrayList<URL>();
+		for (String entry : StringUtils.delimitedListToStringArray(classPathAttribute,
+				" ")) {
+			try {
+				urls.add(new URL(base, entry));
+			}
+			catch (MalformedURLException ex) {
+				throw new IllegalStateException(
+						"Class-Path attribute contains malformed URL", ex);
 			}
 		}
 		return urls;

spring-boot-devtools/src/test/java/org/springframework/boot/devtools/restart/ChangeableUrlsTests.java

@@ -24,6 +24,7 @@
 import java.util.jar.Attributes;
 import java.util.jar.JarOutputStream;
 import java.util.jar.Manifest;
+import java.util.zip.ZipOutputStream;
 
 import org.junit.Rule;
 import org.junit.Test;
@@ -80,7 +81,7 @@ public void urlsFromJarClassPathAreConsidered() throws Exception {
 		File relative = this.temporaryFolder.newFolder();
 		ChangeableUrls urls = ChangeableUrls.fromUrlClassLoader(new URLClassLoader(
 				new URL[] { makeJarFileWithUrlsInManifestClassPath(projectCore,
-						projectWeb, relative.getName() + "/") }));
+						projectWeb, relative.getName() + "/"), makeJarFileWithNoManifest() }));
 		assertThat(urls.toList(),
 				contains(projectCore, projectWeb, relative.toURI().toURL()));
 	}
@@ -105,4 +106,10 @@ private URL makeJarFileWithUrlsInManifestClassPath(Object... urls) throws Except
 		return classpathJar.toURI().toURL();
 	}
 
+	private URL makeJarFileWithNoManifest() throws Exception {
+		File classpathJar = this.temporaryFolder.newFile("no-manifest.jar");
+		new ZipOutputStream(new FileOutputStream(classpathJar)).close();
+		return classpathJar.toURI().toURL();
+	}
+
 }