Skip to content

Commit fa9724b

Browse files
committed
Revert "Add or avoid proxy configurations for integration tests"
This reverts commit 251f280.
1 parent 251f280 commit fa9724b

File tree

6 files changed

+13
-42
lines changed

6 files changed

+13
-42
lines changed

README.adoc

-3
Original file line numberDiff line numberDiff line change
@@ -111,9 +111,6 @@ tests there (e.g. in Eclipse go to `Preferences->Java->Installed JREs` and edit
111111
JRE definition so that all processes are launched with those arguments). This property
112112
is automatically set if you use the maven wrapper.
113113

114-
NOTE: Make sure that your Git config property "core.autocrlf" setting is set to true
115-
under Windows to avoid build and test failures due to missing CRLF EOL characters.
116-
117114
_Also see link:CONTRIBUTING.adoc[CONTRIBUTING.adoc] if you wish to submit pull requests,
118115
and in particular please fill out the
119116
https://support.springsource.com/spring_committer_signup[Contributor's Agreement]

spring-boot-integration-tests/spring-boot-gradle-tests/src/test/java/org/springframework/boot/gradle/ProjectCreator.java

+1-21
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,7 @@
1616

1717
package org.springframework.boot.gradle;
1818

19-
import java.io.BufferedWriter;
2019
import java.io.File;
21-
import java.io.FileWriter;
2220
import java.io.IOException;
2321

2422
import org.gradle.tooling.GradleConnector;
@@ -48,8 +46,7 @@ public ProjectConnection createProject(String name) throws IOException {
4846
projectDirectory.mkdirs();
4947

5048
File gradleScript = new File(projectDirectory, "build.gradle");
51-
writeGradleProperties(projectDirectory);
52-
49+
5350
if (new File("src/test/resources", name).isDirectory()) {
5451
FileSystemUtils.copyRecursively(new File("src/test/resources", name),
5552
projectDirectory);
@@ -65,21 +62,4 @@ public ProjectConnection createProject(String name) throws IOException {
6562
((DefaultGradleConnector) gradleConnector).embedded(true);
6663
return gradleConnector.forProjectDirectory(projectDirectory).connect();
6764
}
68-
69-
private void writeGradleProperties(File projectDirectory) throws IOException {
70-
File gradleProperties = new File(projectDirectory, "gradle.properties");
71-
BufferedWriter writer = new BufferedWriter(new FileWriter(gradleProperties));
72-
writeProperty(writer, "http.proxyHost");
73-
writeProperty(writer, "https.proxyHost");
74-
writeProperty(writer, "http.proxyPort");
75-
writeProperty(writer, "https.proxyPort");
76-
writer.close();
77-
}
78-
79-
private void writeProperty(BufferedWriter writer, String name) throws IOException {
80-
String value = System.getProperty(name);
81-
if (value != null) {
82-
writer.write("systemProp." + name + "=" + value + "\n");
83-
}
84-
}
8565
}

spring-boot-integration-tests/spring-boot-gradle-tests/src/test/java/org/springframework/boot/starter/StarterDependenciesIntegrationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ public static void closeProject() {
9191

9292
public StarterDependenciesIntegrationTests(String starter) {
9393
this.buildArguments = new String[] { "-Pstarter=" + starter,
94-
"-PbootVersion=" + bootVersion, "-PspringVersion=" + springVersion, "--stacktrace" };
94+
"-PbootVersion=" + bootVersion, "-PspringVersion=" + springVersion };
9595
}
9696

9797
@Test

spring-boot-samples/spring-boot-sample-ant/ivysettings.xml

+4
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@
77
<artifact pattern="${user.home}/.m2/repository/[organisation]/[module]/[revision]/[module]-[revision].[ext]" />
88
<ivy pattern="${user.home}/.m2/repository/[organisation]/[module]/[revision]/[module]-[revision].pom" />
99
</filesystem>
10+
<ibiblio name="ibiblio" m2compatible="true" />
11+
<ibiblio name="spring-milestones" m2compatible="true" root="http://repo.spring.io/release" />
12+
<ibiblio name="spring-milestones" m2compatible="true" root="http://repo.spring.io/milestone" />
13+
<ibiblio name="spring-snapshots" m2compatible="true" root="http://repo.spring.io/snapshot" />
1014
</chain>
1115
</resolvers>
1216
</ivysettings>

spring-boot-tools/spring-boot-antlib/pom.xml

+1-15
Original file line numberDiff line numberDiff line change
@@ -36,21 +36,7 @@
3636
<version>${ant.version}</version>
3737
<scope>provided</scope>
3838
</dependency>
39-
<!-- The antunit tests require joda-time -->
40-
<dependency>
41-
<groupId>joda-time</groupId>
42-
<artifactId>joda-time</artifactId>
43-
<version>${joda-time.version}</version>
44-
<scope>compile</scope>
45-
</dependency>
46-
<!-- This is an optional depencency in the joda-time 2.8.1 pom.xml but Ivy tries to resolve it -->
47-
<dependency>
48-
<groupId>org.joda</groupId>
49-
<artifactId>joda-convert</artifactId>
50-
<version>1.2</version>
51-
<scope>compile</scope>
52-
</dependency>
53-
</dependencies>
39+
</dependencies>
5440
<build>
5541
<plugins>
5642
<plugin>

spring-boot-tools/spring-boot-antlib/src/it/sample/ivysettings.xml

+6-2
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,13 @@
44
<chain name="chain">
55
<!-- NOTE: You should declare only repositories that you need here -->
66
<filesystem name="local" local="true" m2compatible="true">
7-
<artifact pattern="${user.home}/.m2/repository/[organisation]/[module]/[revision]/[module]-[revision].[ext]" />
8-
<ivy pattern="${user.home}/.m2/repository/[organisation]/[module]/[revision]/[module]-[revision].pom" />
7+
<artifact pattern="${user.home}/.m2/[organisation]/[module]/[revision]/[module]-[revision].[ext]" />
8+
<ivy pattern="${user.home}/.m2/[organisation]/[module]/[revision]/[module]-[revision].pom" />
99
</filesystem>
10+
<ibiblio name="ibiblio" m2compatible="true" />
11+
<ibiblio name="spring-milestones" m2compatible="true" root="http://repo.spring.io/release" />
12+
<ibiblio name="spring-milestones" m2compatible="true" root="http://repo.spring.io/milestone" />
13+
<ibiblio name="spring-snapshots" m2compatible="true" root="http://repo.spring.io/snapshot" />
1014
</chain>
1115
</resolvers>
1216
</ivysettings>

0 commit comments

Comments
 (0)