Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update codebase to use logging over generic print statements #2

Open
exoticDFT opened this issue Sep 25, 2020 · 0 comments
Open

Update codebase to use logging over generic print statements #2

exoticDFT opened this issue Sep 25, 2020 · 0 comments
Labels
Comp: Core Issues related to the core functionality of the AV stack, e.g. logging, launching, etc. Priority: 2 - Minor Should take minimal time and do not significantly influence the functionality Type: Enhancement Approved issues that will help enhance our AV stack Type: Task Issues that help improve minor parts of the code and not necessarily functionality

Comments

@exoticDFT
Copy link
Member

Throughout the codebase we are using the print function to log information about the system. Instead of this, we should use the ROS logging or python logging functionality. Some notes from ROS on using the various logging levels http://wiki.ros.org/Verbosity%20Levels.
@exoticDFT exoticDFT added Priority: 2 - Minor Should take minimal time and do not significantly influence the functionality Type: Enhancement Approved issues that will help enhance our AV stack Type: Task Issues that help improve minor parts of the code and not necessarily functionality labels Sep 25, 2020
exoticDFT added a commit that referenced this issue Sep 25, 2020
@exoticDFT
Issue #2: Adds logging to the ado vehicle filter
ffe87b2 
- Replaces some potential debug print statements with ROS debug logging functions.
- Adds several extra ROS debug the info logging functions throughout the node.
exoticDFT added a commit that referenced this issue Sep 25, 2020
@exoticDFT
Issues #2 & #3: Adds logging to the controller node
c8f0ee7 
- Replaces some print statements with ROS logging functions.
- Adds several extra ROS debug the info logging functions throughout the node.
- Removes some unnecessary commented code.
exoticDFT added a commit that referenced this issue Sep 25, 2020
@exoticDFT
Issues #2: Adds logging to the controller node
4935e20 
- Adds some new ROS logging messages during initialization.
- Removes some unnecessary code.
- Adds new function for computing the longitudinal parameters for the Ackermann message.
@exoticDFT exoticDFT added the Comp: Core Issues related to the core functionality of the AV stack, e.g. logging, launching, etc. label Sep 30, 2020
exoticDFT added a commit that referenced this issue Oct 6, 2020
@exoticDFT
Issue #2 & #4: Updates the map updater code
8df4765 
- Adds function for handling the parsing of the route csv file to use in the map updater.
- Removes specific circle routes.
- Removes handling of circle specific routes.
- Removes functionality from callback to switch to secondary mode.
- Adds some logging to the amp updater code.
exoticDFT added a commit that referenced this issue Oct 6, 2020
@exoticDFT
Issue #2 & #3: Updates the visualization nodes
3b6c044 
- Adds docstrings to the classes and functions of the visualization_classespy file.
- Cleans up code by formatting to meet the PEP8 standard.
- Adds some logging information to the main visualization node.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Comp: Core Issues related to the core functionality of the AV stack, e.g. logging, launching, etc. Priority: 2 - Minor Should take minimal time and do not significantly influence the functionality Type: Enhancement Approved issues that will help enhance our AV stack Type: Task Issues that help improve minor parts of the code and not necessarily functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@exoticDFT