namespace change url bug (#286)

* added navigate in form

* added namespace sub to details page

---------

Co-authored-by: Mathis Marcotte <[email protected]>

Author: mathis-marcotte

frontend/jupyter/src/app/pages/form/form-new/form-new.component.ts

@@ -64,6 +64,9 @@ export class FormNewComponent
         if (Array.isArray(namespace)) {
           this.goToNotebooks();
         } else {
+          if (this.currNamespace && this.currNamespace !== namespace) {
+            this.router.navigate(['/']);
+          }
           this.currNamespace = namespace;
           this.formCtrl.controls.namespace.setValue(this.currNamespace);
         }

frontend/jupyter/src/app/pages/notebook-page/notebook-page.component.ts

@@ -32,6 +32,7 @@ export class NotebookPageComponent implements OnInit, OnDestroy {
 
   pollSubNotebook = new Subscription();
   pollSubPod = new Subscription();
+  namespaceSub = new Subscription();
 
   constructor(
     public ns: NamespaceService,
@@ -46,7 +47,6 @@ export class NotebookPageComponent implements OnInit, OnDestroy {
   ngOnInit(): void {
     this.route.params.subscribe(params => {
       this.ns.updateSelectedNamespace(params.namespace);
-
       this.notebookName = params.notebookName;
       this.namespace = params.namespace;
 
@@ -58,11 +58,20 @@ export class NotebookPageComponent implements OnInit, OnDestroy {
       this.selectedTab.index = this.switchTab(this.selectedTab.name).index;
       this.selectedTab.name = this.switchTab(this.selectedTab.name).name;
     });
+
+    this.namespaceSub.add(
+      this.ns.getSelectedNamespace().subscribe(namespace => {
+        if (this.namespace && this.namespace !== namespace) {
+          this.router.navigate(['/']);
+        }
+      }),
+    );
   }
 
   ngOnDestroy() {
     this.pollSubNotebook.unsubscribe();
     this.pollSubPod.unsubscribe();
+    this.namespaceSub.unsubscribe();
   }
 
   private poll(namespace: string, notebook: string) {

frontend/jupyter/src/app/pages/volume-details-page/volume-details-page.component.ts

@@ -39,6 +39,7 @@ export class VolumeDetailsPageComponent implements OnInit, OnDestroy {
   } = { index: 0, name: 'overview' };
 
   pollSub = new Subscription();
+  namespaceSub = new Subscription();
 
   constructor(
     public ns: NamespaceService,
@@ -52,7 +53,6 @@ export class VolumeDetailsPageComponent implements OnInit, OnDestroy {
   ngOnInit(): void {
     this.route.params.subscribe(params => {
       this.ns.updateSelectedNamespace(params.namespace);
-
       this.name = params.pvcName;
       this.namespace = params.namespace;
 
@@ -62,10 +62,19 @@ export class VolumeDetailsPageComponent implements OnInit, OnDestroy {
     this.route.queryParams.subscribe(params => {
       this.selectedTab = this.newTab(params.tab);
     });
+
+    this.namespaceSub.add(
+      this.ns.getSelectedNamespace().subscribe(namespace => {
+        if (this.namespace && this.namespace !== namespace) {
+          this.router.navigate(['/']);
+        }
+      }),
+    );
   }
 
   ngOnDestroy() {
     this.pollSub.unsubscribe();
+    this.namespaceSub.unsubscribe();
   }
 
   private poll(namespace: string, name: string) {