Skip to content

Commit d49a982

Browse files
mathis-marcotteMathis Marcotte
and
Mathis Marcotte
authored
replaced dockle with hadolint (#326)
Co-authored-by: Mathis Marcotte <[email protected]>
1 parent 37e41f8 commit d49a982

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

.github/workflows/publish.yml

+6-10
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ env:
1717
DEV_REGISTRY_NAME: k8scc01covidacrdev
1818
TRIVY_VERSION: "v0.43.1"
1919
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
20+
HADOLINT_VERSION: "2.12.0"
2021

2122
jobs:
2223
build:
@@ -65,6 +66,11 @@ jobs:
6566
username: ${{ secrets.DEV_REGISTRY_USERNAME }}
6667
password: ${{ secrets.DEV_REGISTRY_PASSWORD }}
6768

69+
- name: Run Hadolint
70+
run: |
71+
sudo curl -L https://github.com/hadolint/hadolint/releases/download/v${{ env.HADOLINT_VERSION }}/hadolint-Linux-x86_64 --output hadolint
72+
sudo chmod +x hadolint
73+
./hadolint ./Dockerfile --no-fail
6874
6975
- name: Build image locally
7076
run: |
@@ -76,16 +82,6 @@ jobs:
7682
run: |
7783
curl -sfL https://raw.githubusercontent.com/aquasecurity/trivy/main/contrib/install.sh | sh -s -- -b /usr/local/bin ${{ env.TRIVY_VERSION }}
7884
trivy image localhost:5000/jupyter-apis-aaw2:${{ github.sha }} --exit-code 1 --timeout=20m --security-checks vuln --severity CRITICAL
79-
80-
# Run Dockle -> Will need to be replace to hadolint but on hold
81-
# - name: Run dockle
82-
# uses: goodwithtech/dockle-action@main
83-
# with:
84-
# image: localhost:5000/jupyter-apis-aaw2:${{ github.sha }}
85-
# format: 'list'
86-
# exit-code: '0'
87-
# exit-level: 'fatal'
88-
# ignore: 'DKL-DI-0006'
8985
9086
# Container build and push to a Azure Container registry (ACR)
9187
- name: Push to ACR if necessary

0 commit comments

Comments
 (0)