Skip to content

Commit 84474dd

Browse files
authored
Merge pull request #74 from StatelessStudio/v0.5.2
V0.5.2
2 parents 2fb42cc + f92206f commit 84474dd

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

CHANGELOG.md

+5
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# PointyApi Changelog
22

3+
## [0.5.2] Dec-31-2018
4+
5+
### Fixes
6+
- [Issue #73] Object alias should be prepended to order by key regardless of joins
7+
38
## [0.5.1] Dec-31-2018
49

510
### Fixes

package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "pointyapi",
3-
"version": "0.5.1",
3+
"version": "0.5.2",
44
"author": "stateless-studio",
55
"license": "MIT",
66
"scripts": {

src/middleware/get-query.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,6 @@ export async function getQuery(
303303
.select(readableFields);
304304

305305
// Loop through join tables
306-
const hasJoinMembers = request.joinMembers.length > 0;
307306
for (const table of request.joinMembers) {
308307
selection = await selection.leftJoinAndSelect(
309308
`${objMnemonic}.${table}`,
@@ -326,7 +325,7 @@ export async function getQuery(
326325

327326
// Object alias must be prepended if join tables exist,
328327
// but this field isn't from a join
329-
if (hasJoinMembers && !key.includes('.')) {
328+
if (!key.includes('.')) {
330329
key = 'obj.' + key;
331330
}
332331

0 commit comments

Comments
 (0)