feature request: add support for keeping TempDir

[ethanpailes]

I would like to be able to conditionally avoid cleaning up a TempDir, and right now there doesn't seem to be an option for that besides resorting to shenanigans to avoid dropping the struct, which would likely lead to some memory leaks. It would be nice to add a disown() method that lets you mark a TempDir or NamedTempFile as not needing to be cleaned up on distruction.

My use case is that I'm using a TempDir as a place to throw some logs during tests and I want to be able to inspect those logs after the fact if I'm iterating on the test by setting an environment variable or something.

[ethanpailes]

Actually, I see now that there is already a keep method for NamedTempFile, so just adding keep support to TempDir would cover this request.

[Stebalien]

This is already supported through TempDir::into_path. The name difference comes from the fact that TempDir was merged in from an existing crate.

I'd add an alias (a new TempDir::keep function) that just calls TempDir::into_path, and deprecate into_path.

[ethanpailes]

It looks like path()/keep() is not quite equivalent to into_path() because

{
    let p = temp_dir.path().clone();
    temp_dir.keep();
    p
}

requires a copy while temp_dir.into_path() does not.

[ethanpailes]

I'll leave any deprecation marker up to you since it seems like they are not quite equivilant.

[Stebalien]

No? keep() returns the path.

[Stebalien]

Well:

• NamedTempFIle::keep returns the file and path.
• TempPath::keep returns the path.

[abrisco]

Any updates here? I'm interested in in making the change but want to know if there's a recommended path forward. My thoughts would be to add some keep function that would toggle a flag and prevent the directory from being removed when the instance is dropped. Does that sound reasonable?