Skip to content

build script - update argument handling #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shawnlaffan opened this issue Feb 18, 2023 · 4 comments
Closed

build script - update argument handling #37

shawnlaffan opened this issue Feb 18, 2023 · 4 comments
Assignees

Comments

@shawnlaffan
Copy link
Contributor

Parts of the system assume the dllsuffix is one or two underscores when it is not passed. This can lead to issues when reusing build artefacts as the extraction code assumes the underscores if no suffix is passed (e.g. #36).

Some means to differentiate not passed from passed would be handy as I have not found a good way yet. Alternately a getopts approach could be tried.
https://www.baeldung.com/linux/bash-parse-command-line-arguments

@shawnlaffan shawnlaffan self-assigned this Feb 18, 2023
@shawnlaffan
Copy link
Contributor Author

Alternately the script could default to the underscores if the second arg is blank or null. If the user wants no dllsuffix then they can pass "none". That would be simpler to implement.

e.g. these will default to __ on 64 bit systems:

./build.sh 5034
./build.sh 5034 ""

This will set dllsuffix to "":

./build.sh 5034 none

@genio
Copy link
Member

genio commented Feb 19, 2023

Let me just put this out there... do we need to worry about 32-bit any longer?

@shawnlaffan
Copy link
Contributor Author

I think not but maybe there are still some uses out there. Certainly there is no reason 32 bit should hold up a release of 64 bit.

@shawnlaffan
Copy link
Contributor Author

PR merged, closing issue.

The 32 bit question should probably be raised on the perl-dist-strawberry issue tracker?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants