create #1
Open
create #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cluppi
reviewed
Jul 30, 2020
| self, email: str, request_datetime: datetime, full_name: str | ||
| ) -> dict: | ||
|
|
||
| signup = self.createSignupObject(full_name, request_datetime) |
| p = Process(target=self.c, args=(email, full_name, request_datetime)) | ||
| p.start() | ||
|
|
||
| def c(self, email, full_name, request_datetime): |
| Item={ | ||
| 'email': email, | ||
| "uuid": str(uuid.uuid4()), | ||
| "name": full_name, |
There was a problem hiding this comment.
duplicate code between this and createSignupObject
|
|
||
| signup = self.createSignupObject(full_name, request_datetime) | ||
|
|
||
| p = Process(target=self.c, args=(email, full_name, request_datetime)) |
There was a problem hiding this comment.
Not sure why a child process is being created to make a call to dynamodb
| response = client.create('[email protected]', '11/10/2020', 'Stu Mason') | ||
|
|
||
|
|
||
| print(result) |
| dynamodb = boto3.resource("dynamodb", region_name="eu-west-1") | ||
|
|
||
| table = dynamodb.create_table( | ||
| TableName="contacts", |
There was a problem hiding this comment.
Table used is signup, but this is creating contacts
|
|
||
| p = Process(target=self.c, args=(email, full_name, request_datetime)) | ||
| p.start() | ||
|
|
There was a problem hiding this comment.
This function isn't returning anything. It's supposed to return a dict
StuMason
commented
Jul 31, 2020
Comment on lines
+49
to
+63
| ContactWrite: | ||
| Type: AWS::Serverless::Function | ||
| Properties: | ||
| CodeUri: . | ||
| Handler: handler_c_contact.h | ||
| Runtime: python3.7 | ||
| Policies: | ||
| - AmazonDynamoDBFullAccess | ||
| Events: | ||
| Write: | ||
| Type: Api | ||
| Properties: | ||
| Path: /write | ||
| RestApiId: !Ref SignupApi | ||
| Method: POST |
There was a problem hiding this comment.
spacing wrong, handler name sucks, policy is too much (just be read/write on the signups table would be idea)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.