Adapt to system sidebar size

As can be set in system settings. The default row height automatically
adjusts, even for group rows, so the delegate method is unneeded. Tweak
the constraints in the row view item to be less hardcoded as well.

Author: NattyNarwhal

Submariner/Database.xib

@@ -81,14 +81,14 @@
                                 <rect key="frame" x="0.0" y="0.0" width="218" height="600"/>
                                 <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMaxY="YES"/>
                                 <subviews>
-                                    <scrollView focusRingType="none" borderType="none" autohidesScrollers="YES" horizontalLineScroll="24" horizontalPageScroll="10" verticalLineScroll="24" verticalPageScroll="10" usesPredominantAxisScrolling="NO" id="11">
+                                    <scrollView focusRingType="none" borderType="none" autohidesScrollers="YES" horizontalLineScroll="28" horizontalPageScroll="10" verticalLineScroll="28" verticalPageScroll="10" usesPredominantAxisScrolling="NO" id="11">
                                         <rect key="frame" x="0.0" y="0.0" width="218" height="600"/>
                                         <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                                         <clipView key="contentView" drawsBackground="NO" id="cdO-el-ZLY">
                                             <rect key="frame" x="0.0" y="0.0" width="218" height="600"/>
                                             <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                                             <subviews>
-                                                <outlineView focusRingType="none" verticalHuggingPriority="750" allowsExpansionToolTips="YES" columnAutoresizingStyle="lastColumnOnly" tableStyle="sourceList" multipleSelection="NO" autosaveColumns="NO" autosaveName="SourceList" rowHeight="24" rowSizeStyle="automatic" viewBased="YES" floatsGroupRows="NO" indentationPerLevel="13" autosaveExpandedItems="YES" indentationMarkerFollowsCell="NO" outlineTableColumn="16" id="15">
+                                                <outlineView focusRingType="none" verticalHuggingPriority="750" allowsExpansionToolTips="YES" columnAutoresizingStyle="lastColumnOnly" tableStyle="sourceList" multipleSelection="NO" autosaveColumns="NO" autosaveName="SourceList" rowHeight="28" rowSizeStyle="systemDefault" viewBased="YES" floatsGroupRows="NO" indentationPerLevel="13" autosaveExpandedItems="YES" indentationMarkerFollowsCell="NO" outlineTableColumn="16" id="15">
                                                     <rect key="frame" x="0.0" y="0.0" width="218" height="600"/>
                                                     <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                                                     <size key="intercellSpacing" width="3" height="0.0"/>

Submariner/SBDatabaseController.m

@@ -1660,14 +1660,6 @@ - (void)outlineViewSelectionDidChange:(NSNotification *)notification {
     }
 }
 
-- (CGFloat)outlineView:(NSOutlineView *)outlineView heightOfRowByItem:(id)item {
-    if ([[item representedObject] isKindOfClass:[SBSection class]]) {
-        return 22.0f;
-    }
-    // Medium size sidebar; https://developer.apple.com/design/human-interface-guidelines/sidebars#macOS
-    return 28.0f;
-}
-
 - (BOOL)outlineView:(NSOutlineView *)outlineView shouldSelectItem:(id)item {
     if([[item representedObject] isKindOfClass:[SBSection class]])
         return NO;

Submariner/SBSourceListViewItem.swift

@@ -11,11 +11,6 @@
 import Cocoa
 
 @objc(SBSourceListViewItem) class SBSourceListViewItem: NSTableCellView {
-    // https://developer.apple.com/design/human-interface-guidelines/sidebars#macOS
-    // Our row height comes from our hosting NSOutlineView's delegate
-    // Small: 16px icons, subheading text; Medium: 20px icons, body text
-    // XXX: Resize to match system sidebar size
-    
     var resource: SBResource! {
         objectValue as? SBResource
     }
@@ -96,11 +91,12 @@ import Cocoa
         imageView.image = self.icon
         self.imageView = imageView
         self.addSubview(imageView)
-        // 28 high sidebar, 4 point to be centered
-        imageView.topAnchor.constraint(equalTo: self.topAnchor, constant: 4.0).isActive = true
+        // image always has a vertical inset of 4px (i.e. medium 28pt row height, 20pt image)
+        // https://developer.apple.com/design/human-interface-guidelines/sidebars#macOS
+        imageView.topAnchor.constraint(equalTo: self.topAnchor, constant: 10.0).isActive = true
+        imageView.bottomAnchor.constraint(equalTo: self.bottomAnchor, constant: -4.0).isActive = true
+        imageView.widthAnchor.constraint(equalTo: self.heightAnchor).isActive = true
         imageView.leadingAnchor.constraint(equalTo: self.leadingAnchor).isActive = true
-        imageView.widthAnchor.constraint(equalToConstant: 20).isActive = true
-        imageView.heightAnchor.constraint(equalToConstant: 20).isActive = true
 
         let textField = NSTextField()
         textField.translatesAutoresizingMaskIntoConstraints = false
@@ -114,11 +110,10 @@ import Cocoa
         // XXX: Seet it here as bindings will set this
         textField.target = self
         textField.action = #selector(SBSourceListViewItem.renameItem(_:))
-        textField.font = NSFont.preferredFont(forTextStyle: .body)
         self.textField = textField
         self.addSubview(textField)
         textField.centerYAnchor.constraint(equalTo: imageView.centerYAnchor).isActive = true
-        textField.leadingAnchor.constraint(equalTo: imageView.trailingAnchor, constant: 4.0).isActive = true
+        textField.leadingAnchor.constraint(equalTo: imageView.trailingAnchor).isActive = true
         // XXX: For some reason, this anchor breaks the editing mode for the text field
         //textField.trailingAnchor.constraint(equalTo: self.trailingAnchor).isActive = true
     }