suppress linking files in UI

I might re-enable later but i suspect importing can go out the window
entirely later. for now, this is easier than bookmark URL support and I
don't want to ship something that's actually been super busted this
whole time.

see discussion in GH-201 and GH-197

Author: NattyNarwhal

README.md

@@ -35,6 +35,10 @@ Doing so isn't fatal (it's not a secret), but it is annoying for other contribut
 * Artists, albums, and tracks can be favourited ("starred" in Subsonic parlance; we use a heart to avoid being confused with ratings).
   * Favourited albums can be recalled in the server albums view.
   * Favourited status is synchronized to the server.
+* Linking artists has been deprecated for now, and hidden behind an manual option.
+  * It requires a lot more work to work correctly with arbitrary directores together with  App Sandbox.
+  * To re-enable it (for now, knowing the issues), run `defaults write fr.read-write.Submariner canLinkImport -bool YES`.
+  * See the discussion thread on https://github.com/SubmarinerApp/Submariner/discussions/201 for possible plans.
 * A directory view has been added, for users of servers that organize files by directory and prefer managing files that way.
 * A basic AppleScript dictionary has been added as a way to inspect and control playback programatically.
 * Albums can be dragged tracklist or playlist drop targets to add their containing tracks.

Submariner/SBAppDelegate.swift

@@ -46,6 +46,7 @@ fileprivate let logger = Logger(subsystem: Bundle.main.bundleIdentifier!, catego
             "deleteAfterPlay": NSNumber(value: false),
             "SkipIncrement": NSNumber(value: 5.0),
             "albumSortOrder": "OldestFirst",
+            "canLinkImport": NSNumber(value: false),
         ]
         UserDefaults.standard.register(defaults: defaults)
 

Submariner/SBDatabaseController.m

@@ -1319,17 +1319,19 @@ - (void)displayViewControllerForResource:(SBResource *)resource {
 
 
 - (BOOL)openImportAlert:(NSWindow *)sender files:(NSArray<NSURL*> *)files {
-    NSAlert *importAlert = [[NSAlert alloc] init];
-    [importAlert setMessageText:@"Do you want to copy the imported audio files?"];
-    [importAlert setInformativeText: @"The files will copied into the library directory, or have the new library items link to the original files."];
-    [importAlert addButtonWithTitle: @"Copy into Library"];
-    [importAlert addButtonWithTitle: @"Link Existing Files"];
-    [importAlert addButtonWithTitle: @"Cancel"];
-    [importAlert beginSheetModalForWindow: sender completionHandler:^(NSModalResponse alertReturnCode) {
-        [self importSheetDidEnd: sender returnCode: alertReturnCode contextInfo: files];
-    }];
-    
-    //[files autorelease];
+    if ([[NSUserDefaults standardUserDefaults] boolForKey: @"canLinkImport"]) {
+        NSAlert *importAlert = [[NSAlert alloc] init];
+        [importAlert setMessageText:@"Do you want to copy the imported audio files?"];
+        [importAlert setInformativeText: @"The files will copied into the library directory, or have the new library items link to the original files."];
+        [importAlert addButtonWithTitle: @"Copy into Library"];
+        [importAlert addButtonWithTitle: @"Link Existing Files"];
+        [importAlert addButtonWithTitle: @"Cancel"];
+        [importAlert beginSheetModalForWindow: sender completionHandler:^(NSModalResponse alertReturnCode) {
+            [self importSheetDidEnd: sender returnCode: alertReturnCode contextInfo: files];
+        }];
+    } else {
+        [self importSheetDidEnd: sender returnCode: NSAlertFirstButtonReturn contextInfo: files];
+    }
     return NO;
 }