Skip to content

Commit a23865b

Browse files
authored
Merge pull request #312 from Sreejit-K/claim-mismatch-on-property-update
claim mis-mapping fix on property update
2 parents c5ce259 + 1dc445e commit a23865b

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

java/middleware-commons/src/main/java/dev/sunbirdrc/registry/middleware/util/JSONUtil.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -501,7 +501,10 @@ private static JsonNode searchClaimOsIdFromRequestProperties(ArrayNode arrayNode
501501
}
502502
}
503503
}
504-
return arrayNode.get(arrayNode.size() - 1);
504+
List<JsonNode> nodeList = new ArrayList<>();
505+
arrayNode.elements().forEachRemaining(nodeList::add);
506+
nodeList.sort(Comparator.comparingLong(node -> node.get("osCreatedAt").asLong()));
507+
return nodeList.get(nodeList.size() -1 );
505508
}
506509

507510
private static boolean isRequestBodyPropertyPresentInClaim(Map<String,List<String>> requestBodyProperty,Map<String,JsonNode> claimEntryProperty){

java/registry/src/main/java/dev/sunbirdrc/registry/controller/RegistryClaimsController.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727

2828
import javax.servlet.http.HttpServletRequest;
2929
import java.util.Collections;
30+
import java.util.Date;
3031

3132
@RestController
3233
@ConditionalOnProperty(name = "claims.enabled", havingValue = "true")
@@ -140,6 +141,7 @@ public ResponseEntity<Object> riseAttestation(HttpServletRequest request, @Reque
140141
if(!propertyData.isNull()) {
141142
attestationRequest.setPropertyData(propertyData);
142143
}
144+
attestationRequest.setOsCreatedAt(new Date());
143145
attestationRequest.setUserId(userId);
144146
attestationRequest.setEmailId(emailId);
145147
String attestationOSID = registryHelper.triggerAttestation(attestationRequest, attestationPolicy);

java/registry/src/main/java/dev/sunbirdrc/registry/model/dto/AttestationRequest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import lombok.Data;
77
import lombok.NoArgsConstructor;
88

9+
import java.util.Date;
910
import java.util.List;
1011
import java.util.Map;
1112

@@ -22,4 +23,5 @@ public class AttestationRequest {
2223
private Map<String, List<String>> propertiesOSID;
2324
private JsonNode propertyData;
2425
private String emailId;
26+
private Date osCreatedAt;
2527
}

0 commit comments

Comments
 (0)