Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in description of tags for the Falaise urn_db_service #79

Closed
fmauger opened this issue Jan 19, 2018 · 1 comment · Fixed by #82
Closed

Bug in description of tags for the Falaise urn_db_service #79

fmauger opened this issue Jan 19, 2018 · 1 comment · Fixed by #82
Assignees

Comments

@fmauger
Copy link
Contributor

fmauger commented Jan 19, 2018

Directory "resources/urn/db" contains a set of files that describe the dependencies between various
setup published in Falaise for simulation/reconstruction processing.
A graph analysis performed on the current description revealed some cycles in the relationships between some urn nodes related to the management and accounting of variant profiles.
This must be fixed. The current model to manage variant profile through their URN identifier is broken.
Work to do:

  • fix some of the "xxx_infos.defs" files to remove some invalid links (backward edges)
  • set a valid scheme to describe correctly the dependencies between setups, variant services and variant profiles and refactor the broken links as forward edges/links
  • modify the flsimulate(-configure) code to take into account these changes while searching default urn associated to a variant profile
  • update the README file to describe the new rules.

A fix already exists as one of my a feature branches. Will PR it ASAP.
To be assigned to fmauger.

@drbenmorgan
Copy link
Member

@fmauger thanks for the report, and we'll await the PR.

I would also add to the todo list additional documentation on the URN model/implementation plus instructions for developers on managing it. This is strongly coupled to #33, #57, and we need to also ensure that #15 isn't repeated. Please review those as part of the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants