test: add async signal tests for events (#17)

soumyamahunt · web-flow · commit 5ce6b1a9f132 · 2023-03-04T22:40:36.000+05:30
* test: add async signal tests for events

* wip: improve test cases
diff --git a/Sources/AsyncObjects/AsyncCountdownEvent.swift b/Sources/AsyncObjects/AsyncCountdownEvent.swift
@@ -1,8 +1,4 @@
-#if swift(>=5.7)
 import Foundation
-#else
-@preconcurrency import Foundation
-#endif
 
 import OrderedCollections
 
diff --git a/Sources/AsyncObjects/AsyncEvent.swift b/Sources/AsyncObjects/AsyncEvent.swift
@@ -1,8 +1,4 @@
-#if swift(>=5.7)
 import Foundation
-#else
-@preconcurrency import Foundation
-#endif
 
 /// An object that controls execution of tasks depending on the signal state.
 ///
diff --git a/Sources/AsyncObjects/AsyncSemaphore.swift b/Sources/AsyncObjects/AsyncSemaphore.swift
@@ -1,8 +1,4 @@
-#if swift(>=5.7)
 import Foundation
-#else
-@preconcurrency import Foundation
-#endif
 
 import OrderedCollections
 
diff --git a/Sources/AsyncObjects/Continuation/ContinuableCollection.swift b/Sources/AsyncObjects/Continuation/ContinuableCollection.swift
@@ -1,8 +1,4 @@
-#if swift(>=5.7)
 import Foundation
-#else
-@preconcurrency import Foundation
-#endif
 
 /// A type that manages a collection of continuations with an associated key.
 ///
diff --git a/Sources/AsyncObjects/Continuation/ContinuableCollectionActor.swift b/Sources/AsyncObjects/Continuation/ContinuableCollectionActor.swift
@@ -1,14 +1,12 @@
-#if swift(>=5.7)
 import Foundation
 
+#if swift(>=5.7)
 /// An actor type that manages a collection of continuations with an associated key.
 ///
 /// On `Swift 5.7` and above [actor isolation bug with protocol conformance](https://forums.swift.org/t/actor-isolation-is-broken-by-protocol-conformance/57040)
 /// is fixed, and hence original protocol can be used without any issue.
 typealias ContinuableCollectionActor = ContinuableCollection
 #else
-@preconcurrency import Foundation
-
 /// An actor type that manages a collection of continuations with an associated key.
 ///
 /// This is to avoid [actor isolation bug with protocol conformance on older `Swift` versions](https://forums.swift.org/t/actor-isolation-is-broken-by-protocol-conformance/57040).
diff --git a/Sources/AsyncObjects/Continuation/TrackedContinuation.swift b/Sources/AsyncObjects/Continuation/TrackedContinuation.swift
@@ -1,8 +1,4 @@
-#if swift(>=5.7)
 import Foundation
-#else
-@preconcurrency import Foundation
-#endif
 
 /// A mechanism to interface between synchronous and asynchronous code,
 /// with tracking state data.
diff --git a/Sources/AsyncObjects/Future.swift b/Sources/AsyncObjects/Future.swift
@@ -1,8 +1,4 @@
-#if swift(>=5.7)
 import Foundation
-#else
-@preconcurrency import Foundation
-#endif
 
 /// An object that eventually produces a single value and then finishes or fails.
 ///
diff --git a/Sources/AsyncObjects/TaskQueue.swift b/Sources/AsyncObjects/TaskQueue.swift
@@ -1,8 +1,4 @@
-#if swift(>=5.7)
 import Foundation
-#else
-@preconcurrency import Foundation
-#endif
 
 import OrderedCollections
 
diff --git a/Tests/AsyncObjectsTests/AsyncCountdownEventTests.swift b/Tests/AsyncObjectsTests/AsyncCountdownEventTests.swift
@@ -17,6 +17,17 @@ class AsyncCountdownEventTests: XCTestCase {
         try await event.wait(forSeconds: 5)
     }
 
+    func testWithIncrementSignalAfterSomeWait() async throws {
+        let event = AsyncCountdownEvent()
+        event.increment(by: 10)
+        try await waitUntil(event, timeout: 5) { $0.currentCount == 10 }
+        Task {
+            try await Task.sleep(seconds: 1)
+            await event.signal(concurrent: 10)
+        }
+        try await event.wait(forSeconds: 10)
+    }
+
     func testWithOverIncrement() async throws {
         let event = AsyncCountdownEvent()
         event.increment(by: 10)
@@ -78,7 +89,7 @@ class AsyncCountdownEventTests: XCTestCase {
         event.signal()
         try await event.wait(forSeconds: 5)
         self.addTeardownBlock { [weak event] in
-            try await waitUntil(event, timeout: 5) { $0.assertReleased() }
+            try await waitUntil(event, timeout: 10) { $0.assertReleased() }
         }
     }
 
diff --git a/Tests/AsyncObjectsTests/AsyncEventTests.swift b/Tests/AsyncObjectsTests/AsyncEventTests.swift
@@ -10,6 +10,15 @@ class AsyncEventTests: XCTestCase {
         try await event.wait(forSeconds: 3)
     }
 
+    func testSignalAfterSomeWait() async throws {
+        let event = AsyncEvent(signaledInitially: false)
+        Task {
+            try await Task.sleep(seconds: 1)
+            event.signal()
+        }
+        try await event.wait(forSeconds: 10)
+    }
+
     func testResetSignal() async throws {
         let event = AsyncEvent()
         event.reset()
@@ -29,7 +38,7 @@ class AsyncEventTests: XCTestCase {
         try await event.wait(forSeconds: 3)
         await task.value
         self.addTeardownBlock { [weak event] in
-            try await waitUntil(event, timeout: 5) { $0.assertReleased() }
+            try await waitUntil(event, timeout: 10) { $0.assertReleased() }
         }
     }
 
diff --git a/Tests/AsyncObjectsTests/AsyncSemaphoreTests.swift b/Tests/AsyncObjectsTests/AsyncSemaphoreTests.swift
@@ -74,7 +74,7 @@ class AsyncSemaphoreTests: XCTestCase {
         let semaphore = AsyncSemaphore(value: 1)
         try await semaphore.wait(forSeconds: 3)
         self.addTeardownBlock { [weak semaphore] in
-            try await waitUntil(semaphore, timeout: 5) { $0.assertReleased() }
+            try await waitUntil(semaphore, timeout: 10) { $0.assertReleased() }
         }
     }
 }
diff --git a/Tests/AsyncObjectsTests/NonThrowingFutureTests.swift b/Tests/AsyncObjectsTests/NonThrowingFutureTests.swift
@@ -58,7 +58,7 @@ class NonThrowingFutureTests: XCTestCase {
         let _ = try await future.wait(forSeconds: 3)
         await task.value
         self.addTeardownBlock { [weak future] in
-            try await waitUntil(future, timeout: 5) { $0.assertReleased() }
+            try await waitUntil(future, timeout: 10) { $0.assertReleased() }
         }
     }
 
diff --git a/Tests/AsyncObjectsTests/TaskOperationTests.swift b/Tests/AsyncObjectsTests/TaskOperationTests.swift
@@ -74,20 +74,14 @@ class TaskOperationTests: XCTestCase {
         try await operation.wait(forSeconds: 3)
     }
 
-    func testFinisheAsyncdWait() async throws {
-        let operation = TaskOperation { /* Do nothing */  }
-        operation.signal()
-        try await operation.wait(forSeconds: 3)
-    }
-
     func testDeinit() async throws {
         let operation = TaskOperation {
             try await Task.sleep(seconds: 1)
         }
         operation.signal()
         try await operation.wait(forSeconds: 5)
         self.addTeardownBlock { [weak operation] in
-            try await waitUntil(operation, timeout: 5) { $0.assertReleased() }
+            try await waitUntil(operation, timeout: 10) { $0.assertReleased() }
         }
     }
 
@@ -235,7 +229,7 @@ class TaskOperationCancellationTests: XCTestCase {
         operation.cancel()
         try await waitUntil(operation, timeout: 3, satisfies: \.isCancelled)
         self.addTeardownBlock { [weak operation] in
-            try await waitUntil(operation, timeout: 5) { $0.assertReleased() }
+            try await waitUntil(operation, timeout: 10) { $0.assertReleased() }
         }
     }
 }
@@ -265,6 +259,10 @@ class TaskOperationTaskManagementTests: XCTestCase {
             XCTAssertFalse(error.localizedDescription.isEmpty)
         default: XCTFail("Unexpected operation result")
         }
+        do {
+            try await operation.wait(forSeconds: 3)
+            XCTFail("Unexpected task progression")
+        } catch is DurationTimeoutError {}
     }
 
     func testNotStartedCancellationError() async throws {
diff --git a/Tests/AsyncObjectsTests/TaskQueueTests.swift b/Tests/AsyncObjectsTests/TaskQueueTests.swift
@@ -70,7 +70,7 @@ class TaskQueueTests: XCTestCase {
         await queue.exec(flags: .barrier) { /* Do nothing */  }
         await queue.exec { /* Do nothing */  }
         self.addTeardownBlock { [weak queue] in
-            try await waitUntil(queue, timeout: 5) { $0.assertReleased() }
+            try await waitUntil(queue, timeout: 10) { $0.assertReleased() }
         }
     }
 }
diff --git a/Tests/AsyncObjectsTests/ThrowingFutureTests.swift b/Tests/AsyncObjectsTests/ThrowingFutureTests.swift
@@ -66,7 +66,7 @@ class ThrowingFutureTests: XCTestCase {
         let _ = try await future.wait(forSeconds: 3)
         await task.value
         self.addTeardownBlock { [weak future] in
-            try await waitUntil(future, timeout: 5) { $0.assertReleased() }
+            try await waitUntil(future, timeout: 10) { $0.assertReleased() }
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ class AsyncSemaphoreTests: XCTestCase {`
`74`	`74`	`let semaphore = AsyncSemaphore(value: 1)`
`75`	`75`	`try await semaphore.wait(forSeconds: 3)`
`76`	`76`	`self.addTeardownBlock { [weak semaphore] in`
`77`		`- try await waitUntil(semaphore, timeout: 5) { $0.assertReleased() }`
	`77`	`+ try await waitUntil(semaphore, timeout: 10) { $0.assertReleased() }`
`78`	`78`	`}`
`79`	`79`	`}`
`80`	`80`	`}`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ class NonThrowingFutureTests: XCTestCase {`
`58`	`58`	`let _ = try await future.wait(forSeconds: 3)`
`59`	`59`	`await task.value`
`60`	`60`	`self.addTeardownBlock { [weak future] in`
`61`		`- try await waitUntil(future, timeout: 5) { $0.assertReleased() }`
	`61`	`+ try await waitUntil(future, timeout: 10) { $0.assertReleased() }`
`62`	`62`	`}`
`63`	`63`	`}`
`64`	`64`
Original file line number	Diff line number	Diff line change
`@@ -74,20 +74,14 @@ class TaskOperationTests: XCTestCase {`
`74`	`74`	`try await operation.wait(forSeconds: 3)`
`75`	`75`	`}`
`76`	`76`
`77`		`- func testFinisheAsyncdWait() async throws {`
`78`		`- let operation = TaskOperation { /* Do nothing */ }`
`79`		`- operation.signal()`
`80`		`- try await operation.wait(forSeconds: 3)`
`81`		`- }`
`82`		`-`
`83`	`77`	`func testDeinit() async throws {`
`84`	`78`	`let operation = TaskOperation {`
`85`	`79`	`try await Task.sleep(seconds: 1)`
`86`	`80`	`}`
`87`	`81`	`operation.signal()`
`88`	`82`	`try await operation.wait(forSeconds: 5)`
`89`	`83`	`self.addTeardownBlock { [weak operation] in`
`90`		`- try await waitUntil(operation, timeout: 5) { $0.assertReleased() }`
	`84`	`+ try await waitUntil(operation, timeout: 10) { $0.assertReleased() }`
`91`	`85`	`}`
`92`	`86`	`}`
`93`	`87`
`@@ -235,7 +229,7 @@ class TaskOperationCancellationTests: XCTestCase {`
`235`	`229`	`operation.cancel()`
`236`	`230`	`try await waitUntil(operation, timeout: 3, satisfies: \.isCancelled)`
`237`	`231`	`self.addTeardownBlock { [weak operation] in`
`238`		`- try await waitUntil(operation, timeout: 5) { $0.assertReleased() }`
	`232`	`+ try await waitUntil(operation, timeout: 10) { $0.assertReleased() }`
`239`	`233`	`}`
`240`	`234`	`}`
`241`	`235`	`}`
`@@ -265,6 +259,10 @@ class TaskOperationTaskManagementTests: XCTestCase {`
`265`	`259`	`XCTAssertFalse(error.localizedDescription.isEmpty)`
`266`	`260`	`default: XCTFail("Unexpected operation result")`
`267`	`261`	`}`
	`262`	`+ do {`
	`263`	`+ try await operation.wait(forSeconds: 3)`
	`264`	`+ XCTFail("Unexpected task progression")`
	`265`	`+ } catch is DurationTimeoutError {}`
`268`	`266`	`}`
`269`	`267`
`270`	`268`	`func testNotStartedCancellationError() async throws {`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ class TaskQueueTests: XCTestCase {`
`70`	`70`	`await queue.exec(flags: .barrier) { /* Do nothing */ }`
`71`	`71`	`await queue.exec { /* Do nothing */ }`
`72`	`72`	`self.addTeardownBlock { [weak queue] in`
`73`		`- try await waitUntil(queue, timeout: 5) { $0.assertReleased() }`
	`73`	`+ try await waitUntil(queue, timeout: 10) { $0.assertReleased() }`
`74`	`74`	`}`
`75`	`75`	`}`
`76`	`76`	`}`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ class ThrowingFutureTests: XCTestCase {`
`66`	`66`	`let _ = try await future.wait(forSeconds: 3)`
`67`	`67`	`await task.value`
`68`	`68`	`self.addTeardownBlock { [weak future] in`
`69`		`- try await waitUntil(future, timeout: 5) { $0.assertReleased() }`
	`69`	`+ try await waitUntil(future, timeout: 10) { $0.assertReleased() }`
`70`	`70`	`}`
`71`	`71`	`}`
`72`	`72`