Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo downloads do not work on v0.2.7 #144

Open
hgy59 opened this issue Feb 9, 2025 · 8 comments
Open

repo downloads do not work on v0.2.7 #144

hgy59 opened this issue Feb 9, 2025 · 8 comments

Comments

@hgy59
Copy link
Contributor

hgy59 commented Feb 9, 2025

neither to download in the package center nor the manual download works

@hgy59
Copy link
Contributor Author

hgy59 commented Feb 9, 2025

@publicarray did you recently update the repo?

@publicarray
Copy link
Member

Yes sorry I forgot to also restart the nginx server. Can you try again?

@publicarray
Copy link
Member

I see this is a different issue

@publicarray
Copy link
Member

I'll revert the changes (back to v0.2.6), I did testing locally but I guess I wasn't thorough enough

@publicarray
Copy link
Member

Revert is completed and I can download packages, How about you @hgy59

@hgy59
Copy link
Contributor Author

hgy59 commented Feb 9, 2025

@publicarray thanks, it's working again

@mreid-tt
Copy link
Contributor

mreid-tt commented Feb 20, 2025

@hgy59 Sorry, I missed this earlier. I've updated my watch settings for this repo to "All Activity" instead of just "Participating and Mentions," so I should catch issues like this going forward. Could you share more details on what happened? I'd like to try replicating the issue.

@mreid-tt mreid-tt reopened this Feb 20, 2025
@mreid-tt mreid-tt changed the title repo does not work anymore repo downloads do not work on v0.2.7 Feb 20, 2025
@mreid-tt
Copy link
Contributor

@hgy59, @publicarray, I've been investigating the differences between the catalog returned by our server and Synology’s server using the files in this directory:

$ ls -al /run/synopkg/pkglist/
total 516
drwxr-xr-x 2 root root    140 Feb 20 21:25 .
drwxr-xr-x 3 root root     80 Feb 20 21:09 ..
-rw------- 1 root root  25979 Feb 20 21:25 installed.enu
-rw------- 1 root root    965 Feb 20 21:23 otherserver.filtered.enu
-rw------- 1 root root   2078 Feb 20 21:23 otherserver.raw.enu
-rw------- 1 root root 238635 Feb 20 21:24 synoserver.filtered.enu
-rw------- 1 root root 246385 Feb 20 21:09 synoserver.raw.enu

Synology’s catalog includes both a packages section and a beta_packages section, whereas our server only returns a packages section. I initially suspected this might explain why beta packages from our server don’t appear in DSM 7’s Package Center as they do in DSM 6.

To test this, I implemented the required changes in my branch (main...mreid-tt:spkrepo:add-catalog-beta_packages) and confirmed that the expected output was generated. However, neither DSM 7.1 nor 7.2 recognized this information to display community beta packages.

Based on these findings, I believe that DSM versions beyond 6 no longer support displaying beta packages from third-party sources. Furthermore, due to how our queries work—fetching the latest build and either including or excluding betas—if the latest build is a beta version, it won’t appear in DSM 7’s Package Center when beta packages are included in the request.

I verified this further by removing the line that sets entry["beta"] = True, and in doing so, the latest beta version of Monit did appear in the Package Center (albeit without the beta label).

Next Steps

Given this behavior, how should we proceed? My recommendation is to restrict the beta function for DSM 7 users so that it only returns the latest non-beta packages. This would:

  • Ensure that packages with both beta and non-beta versions don’t become invisible to DSM 7 users.
  • Maintain full functionality for DSM 6 users, where beta packages are still supported.

I believe this is the root cause of the issue described in #141 (comment), and a fix has been proposed in #145.

Let me know your thoughts! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants