cleaned logging and added setting to log even less

Author: EzioTheDeadPoet

CHANGELOG.md

@@ -3,8 +3,11 @@
 ## Version 4.0.0 - 23.11.2024
 * Added [Syllabore](https://github.com/kesac/Syllabore) support for Name Generation
 * Made the Names more variable and not fully stuck to what their EditorID would be.
-* With the default settings and all the Anniversary Edition DLC Content Installed the patcher finished in ~2 minutes.
 * Renamed more parts of the Patcher to Synthesis RPG Loot from Halgaris RPG Loot.
+* Reduced the amount of logging and added a toggle to disable logging for individual items for better performance.
+  * Using the default settings and all the Anniversary Edition DLC Content Installed (On an AMD Ryzen 5 7600X CPU)
+    * Runtime with logging for individual items disabled 1.8 min.
+    * Runtime with logging for individual items enabled 2 min.
 
 ## Version 3.2.0 - 06.04.2024
 * Fixed unplayable armor and weapon records being used in the patcher

SynthesisRPGLoot/Analyzers/ArmorAnalyzer.cs

@@ -155,8 +155,7 @@ protected override void AnalyzeGear()
 
                     var newEnchantmentsForName = GetEnchantmentsStringForName(resolvedEnchantments);
                     var enchants = AllRpgEnchants[i];
-                    Console.WriteLine("Generated raw " + RarityClasses[i].Label + ItemTypeDescriptor +
-                                      " enchantment of " + newEnchantmentsForName);
+
                     if (!enchants.ContainsKey(RarityClasses[i].Label + " " + newEnchantmentsForName))
                     {
                         enchants.Add(RarityClasses[i].Label + " " + newEnchantmentsForName, resolvedEnchantments);
@@ -184,7 +183,6 @@ protected override FormKey EnchantItem(ResolvedListItem<IArmorGetter> item, int
                     return armorGetter.FormKey;
                 }
 
-                Console.WriteLine("Generating Enchanted version of " + itemName);
                 var newArmor = State.PatchMod.Armors.AddNewLocking(State.PatchMod.GetNextFormKey());
                 newArmor.DeepCopyIn(item.Resolved);
                 newArmor.EditorID = newArmorEditorId;
@@ -199,13 +197,14 @@ protected override FormKey EnchantItem(ResolvedListItem<IArmorGetter> item, int
                 {
                     newArmor.Keywords?.Add(Skyrim.Keyword.MagicDisallowEnchanting);
                 }
-
-                Console.WriteLine("Generated " + newArmor.Name);
+                
+                if (Program.Settings.GeneralSettings.LogGeneratedItems)
+                    Console.WriteLine($"Generated {newArmor.Name}");
+                
                 return newArmor.FormKey;
             }
             else
             {
-                Console.WriteLine("Generating unenchanted version of " + itemName);
                 var newArmorEditorId = EditorIdPrefix + item.Resolved.EditorID;
                 if (State.LinkCache.TryResolve<IArmorGetter>(newArmorEditorId, out var armorGetter))
                 {
@@ -219,9 +218,9 @@ protected override FormKey EnchantItem(ResolvedListItem<IArmorGetter> item, int
                 newArmor.Name = RarityClasses[rarity].Label.Equals("")
                     ? itemName
                     : RarityClasses[rarity].Label + " " + itemName;
-
-                Console.WriteLine("Generated " + newArmor.Name);
-
+                
+                if (Program.Settings.GeneralSettings.LogGeneratedItems)
+                    Console.WriteLine($"Generated {newArmor.Name}");
 
                 return newArmor.FormKey;
             }

SynthesisRPGLoot/Analyzers/GearAnalyzer.cs

@@ -191,8 +191,6 @@ protected FormKey GenerateEnchantment(int rarity)
                 return objectEffectGetter.FormKey;
             }
 
-            Console.WriteLine("Generating " + RarityClasses[rarity].Label + ItemTypeDescriptor + " enchantment of " +
-                              GetEnchantmentsStringForName(effects));
             var newObjectEffectGetter = State.PatchMod.ObjectEffects.AddNewLocking(State.PatchMod.GetNextFormKey());
             newObjectEffectGetter.DeepCopyIn(effects.First().Enchantment);
             newObjectEffectGetter.EditorID = objectEffectEditorId;
@@ -205,7 +203,6 @@ protected FormKey GenerateEnchantment(int rarity)
             ChosenRpgEnchants[rarity].Add(RarityClasses[rarity].Label + " " + GetEnchantmentsStringForName(effects),
                 newObjectEffectGetter.FormKey);
             ChosenRpgEnchantEffects[rarity].Add(newObjectEffectGetter.FormKey, effects);
-            Console.WriteLine("Enchantment Generated");
             return newObjectEffectGetter.FormKey;
         }
 

SynthesisRPGLoot/Analyzers/WeaponAnalyzer.cs

@@ -155,8 +155,7 @@ protected override void AnalyzeGear()
 
                     var newEnchantmentsForName = GetEnchantmentsStringForName(resolvedEnchantments);
                     var enchants = AllRpgEnchants[i];
-                    Console.WriteLine("Generated raw " + RarityClasses[i].Label + ItemTypeDescriptor +
-                                      " enchantment of " + newEnchantmentsForName);
+                    
                     if (!enchants.ContainsKey(RarityClasses[i].Label + " " + newEnchantmentsForName))
                     {
                         enchants.Add(RarityClasses[i].Label + " " + newEnchantmentsForName, resolvedEnchantments);
@@ -184,7 +183,6 @@ protected override FormKey EnchantItem(ResolvedListItem<IWeaponGetter> item, int
                     return weaponGetter.FormKey;
                 }
 
-                Console.WriteLine("Generating Enchanted version of " + itemName);
                 var newWeapon = State.PatchMod.Weapons.AddNewLocking(State.PatchMod.GetNextFormKey());
                 newWeapon.DeepCopyIn(item.Resolved);
                 newWeapon.EditorID = newWeaponEditorId;
@@ -200,12 +198,13 @@ protected override FormKey EnchantItem(ResolvedListItem<IWeaponGetter> item, int
                     newWeapon.Keywords?.Add(Skyrim.Keyword.MagicDisallowEnchanting);
                 }
 
-                Console.WriteLine("Generated " + newWeapon.Name);
+                if (Program.Settings.GeneralSettings.LogGeneratedItems)
+                    Console.WriteLine($"Generated {newWeapon.Name}");
+
                 return newWeapon.FormKey;
             }
             else
             {
-                Console.WriteLine("Generating unenchanted version of " + itemName);
                 var newWeaponEditorId = EditorIdPrefix + item.Resolved.EditorID;
                 if (State.LinkCache.TryResolve<IWeaponGetter>(newWeaponEditorId, out var weaponGetter))
                 {
@@ -218,9 +217,9 @@ protected override FormKey EnchantItem(ResolvedListItem<IWeaponGetter> item, int
                 newWeapon.Name = RarityClasses[rarity].Label.Equals("")
                     ? itemName
                     : RarityClasses[rarity].Label + " " + itemName;
-
-                Console.WriteLine("Generated " + newWeapon.Name);
-
+                
+                if (Program.Settings.GeneralSettings.LogGeneratedItems)
+                    Console.WriteLine($"Generated {newWeapon.Name}");
 
                 return newWeapon.FormKey;
             }

SynthesisRPGLoot/Settings/GeneralSettings.cs

@@ -14,6 +14,10 @@ namespace SynthesisRPGLoot.Settings;
 public class GeneralSettings
 {
     [MaintainOrder] public int RandomGenerationSeed = 42;
+    
+    [MaintainOrder]
+    [SynthesisTooltip("Disabling this can speed up the generation process.")]
+    public bool LogGeneratedItems = true;
 
     [MaintainOrder]
     [SynthesisSettingName("LeveledList Flags")]