update tests; bump lm version to fix permission issue (#314)

* update tests; bump lm version to fix permission issue

* Update omnibus-sepolia.toml

Author: dbeal-eth

e2e/tasks/getLpPosition.js

@@ -26,21 +26,28 @@ async function getLpPosition({ accountId, poolId, symbol }) {
     config.tokenAddress
   );
   let positionCratio = 0;
+  let vaultCratio = 0;
   try {
-    let positionCratio = await CoreProxy.callStatic.getPositionCollateralRatio(
+    positionCratio = await CoreProxy.callStatic.getPositionCollateralRatio(
+      accountId,
+      poolId,
+      config.tokenAddress
+    );
+    vaultCratio = await CoreProxy.callStatic.getPositionCollateralRatio(
       accountId,
       poolId,
       config.tokenAddress
     );
   } catch (err) {
     log('could not compute cratio for account');
   }
-  log({ accountId, poolId, symbol, positionCollateral, positionCratio, positionDebt });
+  log({ accountId, poolId, symbol, positionCollateral, positionCratio, vaultCratio, positionDebt });
 
   return {
     collateral: parseFloat(ethers.utils.formatUnits(positionCollateral)),
     debt: parseFloat(ethers.utils.formatUnits(positionDebt)),
     positionCratio: parseFloat(ethers.utils.formatUnits(positionCratio)),
+    vaultCratio: parseFloat(ethers.utils.formatUnits(vaultCratio)),
   };
 }
 

e2e/tests/omnibus-mainnet.toml/LegacyMarket.e2e.js

@@ -1,6 +1,7 @@
 const assert = require('assert');
 const { getLpPosition } = require('../../tasks/getLpPosition');
 const { getAccountCollateral } = require('../../tasks/getAccountCollateral');
+const { getCollateralConfig } = require('../../tasks/getCollateralConfig');
 const { ethers } = require('ethers');
 const { syncTime } = require('../../tasks/syncTime');
 const { contractWrite } = require('../../tasks/contractWrite');
@@ -94,7 +95,8 @@ describe(require('path').basename(__filename, '.e2e.js'), function () {
     );
 
     log('the account should have the same debt as before');
-    const newDebt = (await getLpPosition({ accountId, poolId: 1, symbol: 'SNX' })).debt;
+    const lpPosition = await getLpPosition({ accountId, poolId: 1, symbol: 'SNX' });
+    const newDebt = lpPosition.debt;
     log({ newDebt });
     assert.deepEqual(newDebt, debt);
 
@@ -104,6 +106,21 @@ describe(require('path').basename(__filename, '.e2e.js'), function () {
     assert.deepEqual(accountInfo.totalAssigned, accountInfo.totalDeposited);
     // here we just assert that we have more than enough deposited. calculating the actual amount expected would required reading into reward escrow and doing some complicated stuff to figure out already vested amounts and etc.
     assert(accountInfo.totalDeposited - accountInfo.totalLocked >= snxBalance);
+
+    log('the account should not be in liquidatable state');
+    const liquidationRatio = parseFloat(
+      ethers.utils.formatUnits((await getCollateralConfig('SNX')).liquidationRatioD18)
+    );
+
+    log({
+      liquidationRatio,
+      accountRatio: lpPosition.positionCratio,
+      vaultRatio: lpPosition.vaultCratio,
+    });
+
+    // the account should still be healthy after migration (massive sanity check)
+    assert(lpPosition.positionCratio >= liquidationRatio);
+    assert(lpPosition.vaultCratio >= liquidationRatio);
   });
 
   // note: this test effectively has to run after the test above

omnibus-mainnet.toml

@@ -29,7 +29,7 @@ defaultValue = "synthetix-spot-market:3.3.15"
 defaultValue = "synthetix-perps-market:3.3.19"
 
 [setting.legacy_market_package]
-defaultValue = "synthetix-legacy-market:3.3.5"
+defaultValue = "synthetix-legacy-market:3.3.6"
 
 [setting.susde_package]
 defaultValue = 'susde-token'

omnibus-sepolia.toml

@@ -1,5 +1,5 @@
 name = "synthetix-omnibus"
-version = "5"
+version = "6"
 description = "Includes the full synthetix system with configurations applied"
 include = [
     "tomls/settings.toml",
@@ -31,7 +31,7 @@ defaultValue = "synthetix:3.3.18"
 defaultValue = "synthetix-spot-market:3.3.15"
 
 [setting.legacy_market_package]
-defaultValue = "synthetix-legacy-market:3.3.5"
+defaultValue = "synthetix-legacy-market:3.3.6"
 
 [setting.susde_package]
 defaultValue = "fake-susde-token"