Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow @place in postscript #2542

Closed
cthomasdta opened this issue Mar 22, 2024 · 12 comments
Closed

Allow @place in postscript #2542

cthomasdta opened this issue Mar 22, 2024 · 12 comments
Assignees
@ebeshero @sabineseifert
Labels
Type: FeatureRequest
Milestone
Guidelines 4.9.0

Comments

@cthomasdta
Copy link

cthomasdta commented Mar 22, 2024 •
edited
Loading

This was originally discussed with the TEI SIG Correspondence, cf. my initial mail https://listserv.brown.edu/cgi-bin/wa?A2=TEI-CORRESP-SIG;d1a80614.2401. You can read a little more context there, but to keep things very short for the purpose of this issue I will simply quote these few lines:

following the proposals in the Encoding Correspondence Manual on postscripts, Ch. "Postscripts of Letters", https://encoding-correspondence.bbaw.de/v1/postscripts.html, we would raise an issue with the TEI to allow @place in <postscript>.

This is also proposed as one possibility in the chapter:

Furthermore, the <postscript> element should be supplied with an attribute @place to indicate the place where the postscript is entered on the page.

So, the <postscript> element should become a member of class att.placement.
@JanelleJenstad
Copy link
Contributor

This request has my full support. We need @place available to fully describe the mise-en-page of many features of the text. I hope Council will consider other candidates for att.placement while they are considering adding <postscript> to att.placement.

@cthomasdta
Copy link
Author

hope Council will consider other candidates for att.placement

yes, I would argue for <div> as well and could provide an example for a distinct <div type="writingSession"> (not a postscript!) written upside-down at the top of the page. But maybe for now or at least for this issue we stay with the motion for adding <postscript> to att.placement.

@lb42
Copy link
Member

lb42 commented Mar 27, 2024

Making div into a free floating block of text does some violence to its existing semantics, such as they are, in my view. Why not use seg ?

@cthomasdta
Copy link
Author

[…] Why not use seg ?

In my view, a question of priorities, what we want to express: <seg> is very generic, whereas the most important info imo is that this is a <div>, more specifically a <div type="writingSession" n="3">, exactly like the two other <div type="writingSession"> that the letter consists of.

So we have a clear succession of the same elements for the respective text containers (and not div-div-seg -- as if the last one was something else than the two blocks before that):

<div type="letter">
   <div type="writingSession" n="1"><p>[…]</p></div>
   <div type="writingSession" n="2"><p>[…]</p></div>
   <div type="writingSession" n="3"><p>[…]</p></div>
</div>

The (again, imo) a little less important info, but still worth noting preferably as an attribute of this div, is that the third writing session was squeezed in on the top of the page (and written upside-down). Since there is something exactly fitting this annotation demand, namely @place (and maybe @rend), I would like to be able to use it there. [Btw I would argue the same for <head>, but that again would be another issue :)]

I am happy to discuss @place in div in a separate issue. @lb42 should we reference your question/objection in a new one?

For now I would focus on @place in postscript here.

@lb42
Copy link
Member

lb42 commented Mar 27, 2024

Thanks for clarifying your reasoning! It makes sense iff you use div only for "writing sessions" or groups of them, less if you also use them for other hierarchically ordered structural components. Btw, isnt the @change attribute suitable for your purposes?

@cthomasdta
Copy link
Author

Btw, isnt the @change attribute suitable for your purposes?

Hm, at least I don't see it, not as a substitute for @place here, but that's probably not what you had in mind. Anyway, we already use @change for a different distinct purpose, as an easy way to differentiate the writing process in combination with @hand and linking the @change-values to teiHeader/profileDesc/creation/listChange/change.

@sabineseifert sabineseifert self-assigned this Apr 2, 2024
@cthomasdta cthomasdta mentioned this issue Apr 19, 2024
Closed
@sydb sydb added this to the Guidelines 4.8.0 milestone Apr 27, 2024
@sydb
Copy link
Member

sydb commented Apr 27, 2024

Ignoring the entire “maybe <div>, maybe <seg>” side show, I think it quite reasonable to add <postscript> to att.placement.

@sabineseifert
Copy link
Contributor

European subgroup at VF2F April 27:

  • Agreed to add <postScript> to att.placement
  • GR: Overview of members of att.placement to see what the members have all in common
  • one characteristic is that placement is an indicator for the semantic element, i.e. placing allows us to identify a postscript
  • Together with <postScript>, add it to all the other members of model.divBottomPart (<closer>, <postscript>, <signed>, <trailer>) plus <opener> and <salute>

@tuurma
Copy link
Contributor

tuurma commented Oct 6, 2024

Just a note that a bunch of issues seems to be concerned with allowing @place, e.g.

#2572 Add speaker to att.placement
#2551 Allow @place in div
#2550 @hand in emph
#2528 Add sp. to att.placement

@sabineseifert
Copy link
Contributor

After finishing work on PR #2643, this issue will be addressed.

@ebeshero
Copy link
Member

This is related (obviously) to #2551

sydb added a commit that referenced this issue Jan 22, 2025
@sydb
Add postscript element to
2b307d6 
att.placement per #2542. Also fixed a bunch of whitespace
while I was in there.
@sydb sydb mentioned this issue Jan 22, 2025
Closed
sydb added a commit that referenced this issue Jan 22, 2025
@sydb
Add postscript element to
6277543 
att.placement per #2542. Also fixed a bunch of whitespace
while I was in there.
@ebeshero ebeshero self-assigned this Jan 22, 2025
ebeshero added a commit that referenced this issue Jan 22, 2025
@ebeshero
added att.placement to att.transcriptional, modified specs for #2542, #…
ace7189 
…2551
@ebeshero ebeshero mentioned this issue Jan 22, 2025
Merged
raffazizzi added a commit that referenced this issue Jan 22, 2025
@raffazizzi
Merge pull request #2665 from TEIC/ebb-placement-to-transcriptional
0914c29 
added att.placement to att.transcriptional, modified specs for #2542, #2551, #2528, #2572
@raffazizzi
Copy link
Contributor

Fixed by #2665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebeshero ebeshero

@sabineseifert sabineseifert

Labels
Type: FeatureRequest
Projects
None yet
Milestone
Guidelines 4.9.0
Development

No branches or pull requests
8 participants
@sydb @raffazizzi @tuurma @lb42 @ebeshero @sabineseifert @JanelleJenstad @cthomasdta