infra-dp-charts_promotion_1_13 #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nashtapu-tibco
requested review from
Copilot,
dgidwani-tibco,
pagarwal-tibco,
rpratap-tibco and
sasahoo-tibco
There was a problem hiding this comment.
Pull request overview
This PR updates multiple Helm charts to version 1.13.x, with the primary focus on upgrading the HAProxy Ingress Controller chart from version 1.44.5 to 1.46.0 (using Ingress Controller 3.1.14). The changes include enhanced RBAC configuration, improved templating support, updated documentation, and modernized Kubernetes resource management.
Key changes:
- HAProxy chart upgraded to 1.46.0 with Ingress Controller 3.1.14
- Enhanced templating with new helper functions for consistent labeling
- Addition of ClusterRole and ClusterRoleBinding resources for improved RBAC
- Expanded Traefik ingress controller support in o11y-service
- Updated chart versions across multiple components to 1.13.x
Reviewed changes
Copilot reviewed 55 out of 55 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/tp-dp-monitor-agent | Version bumps to 1.13.x with updated build metadata |
| charts/tp-cp-proxy | Version and image tag updates to align with 1.13 release |
| charts/o11y-service | Added OpenSearch configuration support and Traefik middleware definitions |
| charts/dp-core-infrastructure | Version updates for tibtunnel and provisioner-agent sub-charts |
| charts/dp-configure-namespace/charts/haproxy | Major upgrade to 1.46.0 with new RBAC resources, helper templates, and documentation |
| charts/dp-configure-namespace | Updated to use new haproxy 1.46.0 chart and removed discovery-service.yaml |
| charts/artifactmanager | Version bump to 1.13.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
charts/dp-configure-namespace/charts/haproxy/templates/controller-daemonset.yaml
Show resolved
Hide resolved
sasahoo-tibco
approved these changes
Nov 21, 2025
logesh-tibco
approved these changes
Nov 21, 2025
rpratap-tibco
approved these changes
Nov 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates several Helm charts, most notably the
haproxychart used withindp-configure-namespace, with a new version, improved documentation, expanded templating, and enhanced Kubernetes RBAC resources. The main changes include upgrading the HAProxy Ingress Controller version, adding new helper templates and labels, updating RBAC manifests, and providing new documentation and test values for advanced deployment scenarios.Helm Chart and Dependency Upgrades:
haproxychart and its dependency version to1.46.0, updating the base image to Ingress Controller3.1.14and aligningartifactmanageranddp-configure-namespacecharts to new versions. [1] [2] [3] [4]Documentation Improvements:
haproxychart documentation with instructions for OCI-based installation, EKS deployment notes, PodMonitor support, and clarified chart repository usage. [1] [2] [3] [4]Templating and Helper Functions:
_helpers.tplfor consistent labeling and selector generation, and introduced a helper for default backend image pull secrets.RBAC and Kubernetes Resource Enhancements:
clusterrole.yamlandclusterrolebinding.yamltemplates for RBAC, with dynamic rules and labels for the HAProxy Ingress Controller. [1] [2]Test Values and Copyright
ci/directory for different deployment scenarios, and updated copyright years to 2025. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]These updates ensure better maintainability, improved deployment flexibility, and alignment with the latest best practices for Kubernetes and Helm.