Merge pull request #41 from TUK-DP/refactor/37

[refactor] diary/view.py 리팩토링

Author: Leewonchan14

config/basemodel.py

@@ -1,10 +1,23 @@
 from django.db import models
+from django.http import JsonResponse
+from rest_framework import status
 
 
 class BaseModel(models.Model):
     created_at = models.DateTimeField(auto_now_add=True)
     updated_at = models.DateTimeField(auto_now=True)
+
     # deleted_at = models.DateTimeField(blank=True, null=True)
 
     class Meta:
         abstract = True
+
+
+class ApiResponse:
+    @staticmethod
+    def on_success(result, response_status=status.HTTP_200_OK):
+        return JsonResponse({'isSuccess': True, 'result': result}, status=response_status)
+
+    @staticmethod
+    def on_fail(message, response_status=status.HTTP_400_BAD_REQUEST):
+        return JsonResponse({'isSuccess': False, 'message': message}, status=response_status)

diary/serializers.py

@@ -1,4 +1,4 @@
-from rest_framework import serializers
+from rest_framework import serializers, status
 
 from users.models import User
 from users.serializers import UserSafeSerializer
@@ -12,41 +12,47 @@ class Meta:
         model = Diary
         fields = '__all__'
 
+
 class DiarySimpleSerializer(serializers.ModelSerializer):
     user = UserSafeSerializer(read_only=True)
 
     class Meta:
         model = Diary
         fields = ['id', 'user', 'title']
 
+
 class SentenceSerializer(serializers.ModelSerializer):
     diay = DiarySerializer(read_only=True)
 
     class Meta:
         model = Sentences
         fields = '__all__'
 
+
 class SentenceSimpleSerializer(serializers.ModelSerializer):
     diary = DiarySimpleSerializer(read_only=True)
 
     class Meta:
         model = Sentences
         fields = ['id', 'diary', 'sentence']
 
+
 class KeywordSerializer(serializers.ModelSerializer):
     sentence = SentenceSerializer(read_only=True)
 
     class Meta:
         model = Keywords
         fields = '__all__'
 
+
 class QuestionSerializer(serializers.ModelSerializer):
     keyword = KeywordSerializer(read_only=True)
 
     class Meta:
         model = Questions
         fields = '__all__'
 
+
 class DiaryCreateRequest(serializers.ModelSerializer):
     userId = serializers.IntegerField()
 
@@ -60,19 +66,91 @@ def to_diary(self, user: User) -> DiarySerializer:
         newDiary.save(user=user)
         return newDiary
 
+
 class WriteRequest(serializers.Serializer):
     userId = serializers.IntegerField()
     title = serializers.CharField(max_length=100)
     content = serializers.CharField()
 
+    def is_valid(self, raise_exception=False):
+        super_valid = super().is_valid()
+        # 유효하지 않다면 False, 400 반환
+        if not super_valid:
+            return False, status.HTTP_400_BAD_REQUEST
+
+        # 유효하다면 userId가 존재하는지 확인
+        is_user_exist = User.objects.filter(id=self.data['userId']).exists()
+
+        # 존재하지 않는다면 False, 404 반환
+        if not is_user_exist:
+            self._errors['userId'] = [f'userId: {self.data.get("userId")} 가 존재하지 않습니다.']
+            return False, status.HTTP_404_NOT_FOUND
+
+        return True, status.HTTP_200_OK
+
+
 class UpdateRequest(serializers.Serializer):
     diaryId = serializers.IntegerField()
     userId = serializers.IntegerField()
     title = serializers.CharField(max_length=100)
     content = serializers.CharField()
 
+    def is_valid(self, raise_exception=False):
+        super_valid = super().is_valid()
+        # 유효하지 않다면 False, 400 반환
+        if not super_valid:
+            return False, status.HTTP_400_BAD_REQUEST
+
+        # userId가 존재하는지 확인
+        is_user_exist = User.objects.filter(id=self.data['userId']).exists()
+        # 존재하지 않는다면 False, 404 반환
+        if not is_user_exist:
+            self._errors['userId'] = [f'userId: {self.data.get("userId")} 가 존재하지 않습니다.']
+            return False, status.HTTP_404_NOT_FOUND
+
+        # diaryId가 존재하는지 확인
+        is_diary_exist = Diary.objects.filter(id=self.data['diaryId']).exists()
+        # 존재하지 않는다면 False, 404 반환
+        if not is_diary_exist:
+            self._errors['diaryId'] = [f'diaryId: {self.data.get("diaryId")} 가 존재하지 않습니다.']
+            return False, status.HTTP_404_NOT_FOUND
+
+        return True, status.HTTP_200_OK
+
+
 class GetUserRequest(serializers.Serializer):
     userId = serializers.IntegerField()
 
+    def is_valid(self, raise_exception=False):
+        super_valid = super().is_valid()
+        # 유효하지 않다면 False, 400 반환
+        if not super_valid:
+            return False, status.HTTP_400_BAD_REQUEST
+
+        # userId가 존재하는지 확인
+        is_user_exist = User.objects.filter(id=self.data['userId']).exists()
+        # 존재하지 않는다면 False, 404 반환
+        if not is_user_exist:
+            self._errors['userId'] = [f'userId: {self.data.get("userId")} 가 존재하지 않습니다.']
+            return False, status.HTTP_404_NOT_FOUND
+
+        return True, status.HTTP_200_OK
+
+
 class GetDiaryRequest(serializers.Serializer):
-    diaryId = serializers.IntegerField()
+    diaryId = serializers.IntegerField()
+
+    def is_valid(self, raise_exception=False):
+        super_valid = super().is_valid()
+        # 유효하지 않다면 False, 400 반환
+        if not super_valid:
+            return False, status.HTTP_400_BAD_REQUEST
+
+        # diaryId가 존재하는지 확인
+        is_diary_exist = Diary.objects.filter(id=self.data['diaryId']).exists()
+        # 존재하지 않는다면 False, 404 반환
+        if not is_diary_exist:
+            self._errors['diaryId'] = [f'diaryId: {self.data.get("diaryId")} 가 존재하지 않습니다.']
+            return False, status.HTTP_404_NOT_FOUND
+
+        return True, status.HTTP_200_OK

diary/urls.py

@@ -1,11 +1,9 @@
-from django.urls import path, include
-from rest_framework.routers import DefaultRouter
-from .views import DiaryView, WriteView, GetDiarybyUserView, GetQuizView, UpdateView
+from django.urls import path
+from .views import WriteView, GetDiaryByUserView, GetQuizView, UpdateView
 
 urlpatterns = [
-    path('', DiaryView.as_view()),
     path('write', WriteView.as_view()),
-    path('list', GetDiarybyUserView.as_view()),
+    path('list', GetDiaryByUserView.as_view()),
     path('quiz', GetQuizView.as_view()),
     path('update', UpdateView.as_view())
 ]