[fix] 연결된 함수 호출을 분리해서 에러 해결

[fix] 연결된 함수 호출을 분리해서 에러 해결

Author: rvbear

diary/serializers.py

@@ -58,49 +58,12 @@ class WriteRequest(serializers.Serializer):
     title = serializers.CharField(max_length=100)
     content = serializers.CharField()
 
-    class Meta:
-        model = Diary
-        fields = '__all__'
-
-    def create(self, validated_data):
-        user_id = validated_data.pop('userId')
-        try:
-            user = User.objects.get(pk=user_id)
-        except User.DoesNotExist:
-            raise serializers.ValidationError("유저가 존재하지 않습니다.")
-        
-        validated_data['user'] = user
-        content_data = validated_data.pop('content')
-        diary = Diary.objects.create(**validated_data)
-        Sentences.objects.create(diary=diary, sentence=content_data)
-
-        return diary
-
 class UpdateRequest(serializers.Serializer):
     diaryId = serializers.IntegerField()
     userId = serializers.IntegerField()
     title = serializers.CharField(max_length=100)
     content = serializers.CharField()
 
-    class Meta:
-        model = Diary
-        fields = '__all__'
-
-    def create(self, validated_data):
-        diary_id = validated_data.pop('diaryId')
-        user_id = validated_data.pop('userId')
-        try:
-            user = User.objects.get(pk=user_id)
-        except User.DoesNotExist:
-            raise serializers.ValidationError("유저가 존재하지 않습니다.")
-
-        validated_data['user'] = user
-        content_data = validated_data.pop('content')
-        new_diary = Diary.objects.create(**validated_data)
-        Sentences.objects.create(diary=new_diary, sentence=content_data)
-
-        return new_diary
-
 class GetUserRequest(serializers.Serializer):
     userId = serializers.IntegerField()
 

diary/views.py

@@ -47,16 +47,18 @@ def post(self, request):
             except User.DoesNotExist:
                 return JsonResponse({'isSuccess': False, 'message': '사용자를 찾을 수 없습니다.'}, status=status.HTTP_400_BAD_REQUEST)
 
-            diary = serializer.save()
+            diary = Diary.objects.create(user=user, title=serializer.validated_data.get('title'))
 
-            content = Sentences.objects.create(sentence=serializer.validated_data.get('content'), diary=diary)
-            memory = TextRank(content.sentence)
+            content = serializer.validated_data.get('content')
+
+            sentence = Sentences.objects.create(sentence=content, diary=diary)
+
+            memory = TextRank(content=content)
             question, answer = make_quiz(memory, keyword_size=5)
 
-            for q, a in zip(question, answer):
-                Quizs.objects.create(question=q, answer=a, sentence=content)
+            Quizs.objects.bulk_create([Quizs(question=q, answer=a, sentence=sentence) for q, a in zip(question, answer)])
 
-            return JsonResponse({'isSuccess': True, 'result': SentenceSimpleSerializer(content).data}, status=status.HTTP_201_CREATED)
+            return JsonResponse({'isSuccess': True, 'result': SentenceSimpleSerializer(sentence).data}, status=status.HTTP_201_CREATED)
 
         return JsonResponse(serializer.errors, status=status.HTTP_400_BAD_REQUEST)
 
@@ -78,16 +80,18 @@ def post(self, request):
                 deleteDiary = Diary.objects.get(id=diary_id)
                 Diary.delete(deleteDiary)
 
-                updateDiary = serializer.save()
+                diary = Diary.objects.create(user=user, title=serializer.validated_data.get('title'))
+
+                content = serializer.validated_data.get('content')
+
+                sentence = Sentences.objects.create(sentence=content, diary=diary)
 
-                content = Sentences.objects.create(sentence=serializer.validated_data.get('content'), diary=updateDiary)
-                memory = TextRank(content.sentence)
+                memory = TextRank(content=content)
                 question, answer = make_quiz(memory, keyword_size=5)
 
-                for q, a in zip(question, answer):
-                    Quizs.objects.create(question=q, answer=a, sentence=content)
+                Quizs.objects.bulk_create([Quizs(question=q, answer=a, sentence=sentence) for q, a in zip(question, answer)])
 
-                return JsonResponse({'isSuccess': True, 'result': SentenceSimpleSerializer(content).data}, status=status.HTTP_201_CREATED)
+                return JsonResponse({'isSuccess': True, 'result': SentenceSimpleSerializer(sentence).data}, status=status.HTTP_201_CREATED)
             except Diary.DoesNotExist:
                 return JsonResponse({'isSuccess': False, 'message': '일기를 찾을 수 없습니다.'}, status=status.HTTP_400_BAD_REQUEST)
         return JsonResponse(serializer.errors, status=status.HTTP_400_BAD_REQUEST)