multiple rooms in notes

[slayernominee]

If there are multiple rooms show the other rooms in notes

[CommanderStorm]

Could you provide a screenshot of what event you are refering to?
Calendar entrys in TUMonline natively only have one room as far as I have seen

[slayernominee]

they are not the same event but the same course in different rooms and they summarized version only shows the room of the first option

[slayernominee]

so here is only one room in notes listed

[CommanderStorm]

Could you share the source ical of just these events which we are not deduplicating?

Note that we already have deduplication (=> maybe this is not working perfectly?):

CalendarProxy/internal/app_test.go

Lines 59 to 70 in 01b86ba

	func TestDeduplication(t *testing.T) {
	testData, app := getTestData(t, "duplication.ics")
	calendar, err := app.getCleanedCalendar([]byte(testData))
	if err != nil {
	t.Error(err)
	return
	}
	if len(calendar.Components) != 1 {
	t.Errorf("Calendar should have only 1 entry after deduplication but has %d", len(calendar.Components))
	return
	}
	}

This is the function that does the deduplication (PR welome, if you want to give this a try ^^):

CalendarProxy/internal/app.go

Lines 167 to 194 in 01b86ba

	func (a *App) getCleanedCalendar(all []byte) (*ics.Calendar, error) {
	cal, err := ics.ParseCalendar(strings.NewReader(string(all)))
	if err != nil {
	return nil, err
	}
	// Create map that tracks if we have allready seen a lecture name & datetime (e.g. "lecturexyz-1.2.2024 10:00" -> true)
	hasLecture := make(map[string]bool)
	var newComponents []ics.Component // saves the components we keep because they are not duplicated
	for _, component := range cal.Components {
	switch component.(type) {
	case *ics.VEvent:
	event := component.(*ics.VEvent)
	dedupKey := fmt.Sprintf("%s-%s", event.GetProperty(ics.ComponentPropertySummary).Value, event.GetProperty(ics.ComponentPropertyDtStart))
	if _, ok := hasLecture[dedupKey]; ok {
	continue
	}
	hasLecture[dedupKey] = true // mark event as seen
	a.cleanEvent(event)
	newComponents = append(newComponents, event)
	default: // keep everything that is not an event (metadata etc.)
	newComponents = append(newComponents, component)
	}
	}
	cal.Components = newComponents
	return cal, nil
	}

[slayernominee]

no no, the deduplication works completly fine, what i mean are the pink ones are the not filtered calendar entries but they have different rooms and they get summarized to one event (in orange) but in the orange entry there is only the note with the room location of one event and not all of them

so basically my idea is just to show all available rooms instead of only one