Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter for versions is incomplete #14

Open
maddy2101 opened this issue May 9, 2021 · 6 comments
Open

Filter for versions is incomplete #14

maddy2101 opened this issue May 9, 2021 · 6 comments
Assignees
Labels

Comments

@maddy2101
Copy link

I searched for a string, got a ton of results, and each has the corresponding version strings applied. Great!

But looking into the sidebar for filters to narrow down the result, I find not all versions from the search result list are available here.

Search-results-for-import

@tmotyl
Copy link
Collaborator

tmotyl commented May 11, 2021

Hi @maddy2101
Right now we're showing only first 10 buckets with highest number of found documents.
Seems that v10.4 had less than 52 documents found, so it was not in the top 10 Versions.
I can of course increase the number of versions shown, but this will not solve the problem (you might have 100 version shown).

@DavidBruchmann
Copy link

Perhaps it's possible to add additional buckets only for the main versions, so that subversions could be ignored?

@tmotyl tmotyl added the todo label Dec 6, 2023
@soee soee self-assigned this Dec 19, 2023
soee pushed a commit to soee/t3docs-search-indexer that referenced this issue Dec 29, 2023
…s for highest versions

This commit replaces the all versions aggregation by only major versions.

There is also change for the search results list. Before labels for all versions assigned to the snippet were rendered. After the changes only
the highest version in given branch will be rendered. For example, if
snippet has versions `main`, `12.4`, `12.0`, `11.5`, `11.3`, `11.0`, `9.5`, only labels for
`main`,`12.4`, `11.5`, `9.5` will be rendered.

Resolves issue: TYPO3-Documentation#14
soee pushed a commit to soee/t3docs-search-indexer that referenced this issue Feb 15, 2024
…s for highest versions

This commit replaces the all versions aggregation by only major versions.

There is also change for the search results list. Before labels for all versions assigned to the snippet were rendered. After the changes only
the highest version in given branch will be rendered. For example, if
snippet has versions `main`, `12.4`, `12.0`, `11.5`, `11.3`, `11.0`, `9.5`, only labels for
`main`,`12.4`, `11.5`, `9.5` will be rendered.

Resolves issue: TYPO3-Documentation#14
soee pushed a commit to soee/t3docs-search-indexer that referenced this issue Feb 16, 2024
…s for highest versions

This commit replaces the all versions aggregation by only major versions.

There is also change for the search results list. Before labels for all versions assigned to the snippet were rendered. After the changes only
the highest version in given branch will be rendered. For example, if
snippet has versions `main`, `12.4`, `12.0`, `11.5`, `11.3`, `11.0`, `9.5`, only labels for
`main`,`12.4`, `11.5`, `9.5` will be rendered.

Resolves issue: TYPO3-Documentation#14
linawolf added a commit that referenced this issue Feb 16, 2024
…stVersionsLabels

#14 Aggregate only major versions and render labels for highest versions
@damienalexandre
Copy link
Contributor

Aggregate on the major version has been done but it's still not sufficient:

image

The top hits versions are so rare they are not showing up in the navigation.

I see two paths here:

  • Increase the number of versions shown (or even add a "see more" button to unfold a bigger list)
  • Try to change the way versions are ordered - we could for example use the documents average score per bucket to sort them instead of using the number of documents ; it's not common and there is no guaranty it will solve the problem.

@linawolf
Copy link
Member

linawolf commented Jan 8, 2025

we should by default only search in the current elts versions for the Core versions. However third party extensions have their own system of versions. We probably have to split the index and not treat core versions like extension versions. And then there are the versions in the changelog which should not be filtered by only elts versions, as changelog entries of all versions should be visible by default

@linawolf
Copy link
Member

linawolf commented Jan 8, 2025

We might be able to reduce the number of versions shown for third party extensions by default by filtering them by their supported TYPO3 versions...

@dogawaf
Copy link

dogawaf commented Feb 10, 2025

Ordering the versions by "main" then descending + a button to "see more versions" would be fine IMHO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants