Skip to content

Commit e906690

Browse files
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
1 parent ae9d982 commit e906690

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

pylint_secure_coding_standard.py

+11-11
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ def _is_allowed_mode(node, allowed_modes, args_idx):
182182

183183

184184
def _is_shell_true_call(node):
185-
_n_args_max = 8
185+
n_args_max = 8
186186
if not (isinstance(node.func, astroid.Attribute) and isinstance(node.func.expr, astroid.Name)):
187187
return False
188188

@@ -199,9 +199,9 @@ def _is_shell_true_call(node):
199199
return True
200200

201201
if (
202-
len(node.args) > _n_args_max
203-
and isinstance(node.args[_n_args_max], astroid.Const)
204-
and bool(node.args[_n_args_max].value)
202+
len(node.args) > n_args_max
203+
and isinstance(node.args[n_args_max], astroid.Const)
204+
and bool(node.args[n_args_max].value)
205205
):
206206
return True
207207

@@ -238,9 +238,9 @@ def _is_mktemp_call(node):
238238

239239

240240
def _is_yaml_unsafe_call(node):
241-
_load_n_args_max = 2
242-
_safe_loaders = ('BaseLoader', 'SafeLoader')
243-
_unsafe_loaders = ('Loader', 'UnsafeLoader', 'FullLoader')
241+
load_n_args_max = 2
242+
safe_loaders = ('BaseLoader', 'SafeLoader')
243+
unsafe_loaders = ('Loader', 'UnsafeLoader', 'FullLoader')
244244

245245
if (
246246
isinstance(node.func, astroid.Attribute)
@@ -255,20 +255,20 @@ def _is_yaml_unsafe_call(node):
255255
if node.func.attrname == 'load' and node.keywords:
256256
for keyword in node.keywords:
257257
if keyword.arg == 'Loader' and isinstance(keyword.value, astroid.Name):
258-
if keyword.value.name in _unsafe_loaders:
258+
if keyword.value.name in unsafe_loaders:
259259
# Cover:
260260
# * yaml.load(x, Loader=Loader).
261261
# * yaml.load(x, Loader=UnsafeLoader).
262262
# * yaml.load(x, Loader=FullLoader).
263263
return True
264-
if keyword.value.name in _safe_loaders:
264+
if keyword.value.name in safe_loaders:
265265
# Cover:
266266
# * yaml.load(x, Loader=BaseLoader).
267267
# * yaml.load(x, Loader=SafeLoader).
268268
return False
269269
elif node.func.attrname == 'load' and (
270-
len(node.args) < _load_n_args_max
271-
or (isinstance(node.args[1], astroid.Name) and node.args[1].name in _unsafe_loaders)
270+
len(node.args) < load_n_args_max
271+
or (isinstance(node.args[1], astroid.Name) and node.args[1].name in unsafe_loaders)
272272
):
273273
# Cover:
274274
# * yaml.load(x).

tests/plugin_options_test.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@
2121

2222

2323
def _id_func(arg):
24-
_max_len = 4
24+
max_len = 4
2525
if arg == _default_modes:
2626
return 'default_modes'
27-
if isinstance(arg, list) and len(arg) > _max_len:
27+
if isinstance(arg, list) and len(arg) > max_len:
2828
return '[{}...{}]'.format(
29-
','.join(str(val) for val in arg[:_max_len]),
30-
','.join(str(val) for val in arg[-_max_len:]),
29+
','.join(str(val) for val in arg[:max_len]),
30+
','.join(str(val) for val in arg[-max_len:]),
3131
)
3232
return str(arg)
3333

0 commit comments

Comments
 (0)