Skip to content

Commit 408f2dc

Browse files
committed
reset react-start files
1 parent 6d09b12 commit 408f2dc

3 files changed

Lines changed: 3 additions & 25 deletions

File tree

e2e/react-start/basic-test-suite/src/special-characters.spec.ts

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,6 @@ test.describe('Unicode route rendering', () => {
6767
})
6868

6969
test.describe('Special characters in search params', () => {
70-
test.skip(
71-
isSpaMode,
72-
'SPA direct navigation currently drops these search-param cases before the route renders',
73-
)
74-
7570
test('should render route correctly on direct navigation', async ({
7671
page,
7772
baseURL,
@@ -228,18 +223,14 @@ test.describe('Unicode route rendering', () => {
228223
const link = page.getByTestId('special-malformed-path-link')
229224

230225
await link.click()
226+
231227
await page.waitForLoadState('load')
232228

233229
await expect(
234230
page.getByTestId('default-not-found-component'),
235231
).toBeInViewport()
236232
})
237233

238-
test.skip(
239-
isSpaMode,
240-
'SPA direct navigation currently drops these search-param cases before the route renders',
241-
)
242-
243234
test('un-matched malformed paths should return not found on direct navigation in search params', async ({
244235
page,
245236
baseURL,

e2e/vue-start/basic-test-suite/src/not-found.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ test.use({
1212
],
1313
})
1414
test.describe('not-found', () => {
15-
test.skip(`global not found`, async ({ page }) => {
15+
test(`global not found`, async ({ page }) => {
1616
const response = await page.goto(`/this-page-does-not-exist/foo/bar`)
1717

1818
expect(response?.status()).toBe(isSpaMode ? 200 : 404)
@@ -84,7 +84,7 @@ test.describe('not-found', () => {
8484
).not.toBeInViewport()
8585
})
8686

87-
test.skip('direct visit: beforeLoad notFound with routeId targets root boundary', async ({
87+
test('direct visit: beforeLoad notFound with routeId targets root boundary', async ({
8888
page,
8989
}) => {
9090
await page.goto('/not-found/via-beforeLoad-target-root')

e2e/vue-start/basic-test-suite/src/special-characters.spec.ts

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -77,23 +77,11 @@ test.describe('Unicode route rendering', () => {
7777
`${baseURL}/specialChars/search?searchParam=%EB%8C%80|`,
7878
)
7979

80-
await page.waitForLoadState('networkidle')
81-
8280
const searchParam = await page
8381
.getByTestId('special-search-param')
8482
.textContent()
8583

8684
expect(searchParam).toBe('대|')
87-
88-
const loadedOn = await page
89-
.getByTestId('special-search-loaded-info')
90-
.textContent()
91-
92-
if (isSpaMode) {
93-
expect(loadedOn).toBe('Loaded on: client')
94-
} else {
95-
expect(loadedOn).toBe('Loaded on: server')
96-
}
9785
})
9886

9987
test('should render route correctly on router navigation', async ({
@@ -223,7 +211,6 @@ test.describe('Unicode route rendering', () => {
223211
const link = page.getByTestId('special-malformed-path-link')
224212

225213
await link.click()
226-
227214
await page.waitForLoadState('load')
228215

229216
await expect(

0 commit comments

Comments
 (0)